empty request

crlssn · Dec 2, 2024 · 6af1c3b · 6af1c3b
1 parent 8c6a47b
commit 6af1c3b
Show file tree

Hide file tree

Showing 6 changed files with 120 additions and 68 deletions.
diff --git a/protobufs/api/v1/notifications.proto b/protobufs/api/v1/notifications.proto
@@ -14,7 +14,7 @@ service NotificationService {
   rpc ListNotifications (ListNotificationsRequest) returns (ListNotificationsResponse) {
     option (auth) = true;
   }
-  rpc UnreadNotifications (google.protobuf.Empty) returns (stream UnreadNotificationsResponse) {
+  rpc UnreadNotifications (UnreadNotificationsRequest) returns (stream UnreadNotificationsResponse) {
     option (auth) = true;
   }
 }
@@ -47,6 +47,7 @@ message Notification {
   }
 }
 
+message UnreadNotificationsRequest {}
 message UnreadNotificationsResponse {
   int64 count = 1;
 }
diff --git a/server/pkg/pb/api/v1/apiv1connect/notifications.connect.go b/server/pkg/pb/api/v1/apiv1connect/notifications.connect.go
diff --git a/server/pkg/pb/api/v1/notifications.pb.go b/server/pkg/pb/api/v1/notifications.pb.go
diff --git a/server/rpc/v1/notification.go b/server/rpc/v1/notification.go
@@ -7,7 +7,6 @@ import (
 
 	"connectrpc.com/connect"
 	"go.uber.org/zap"
-	"google.golang.org/protobuf/types/known/emptypb"
 
 	"github.com/crlssn/getstronger/server/pkg/orm"
 	v1 "github.com/crlssn/getstronger/server/pkg/pb/api/v1"
@@ -109,7 +108,7 @@ func (h *notificationHandler) ListNotifications(ctx context.Context, req *connec
 	}, nil
 }
 
-func (h *notificationHandler) UnreadNotifications(ctx context.Context, _ *connect.Request[emptypb.Empty], res *connect.ServerStream[v1.UnreadNotificationsResponse]) error {
+func (h *notificationHandler) UnreadNotifications(ctx context.Context, _ *connect.Request[v1.UnreadNotificationsRequest], res *connect.ServerStream[v1.UnreadNotificationsResponse]) error {
 	log := xcontext.MustExtractLogger(ctx)
 	userID := xcontext.MustExtractUserID(ctx)