Docker image with pm2 balancer #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Never heard of pm2 before, looks cool. We were discussing if and how to dockerize this project in #4 As I said earlier I don't know if it is worth providing images and/or complex dockerfiles for the project, because it is (in my opinion) out of scope. As of right now I will leave this PR open, it is definitely useful for someone but it might not be useful for the target audience of this repository I will link this PR to the docs so people looking for dockerizing the project will find this Thanks again |
|
Added a link to this PR with 583c506 |
|
Should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Dockerfile to build and run this project.