Transparent buffer around badge to mimic DIscord UI #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A transparent buffer is added surrounding the ping badge. This mimics the Discord UI for notifications.
There is an issue with local beta testing where image commands are not handling transparency in GIFs in the same manner as the bot on the server. This issue affects not only the
>pingbadgecommand, which I modified, but other images commands which I have not modified. In other words, the deployed bot handles GIF transparency well for most commands, whereas my local beta does not. l I won't know if this is going to be an issue until deployment.