-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more info to Contribute section #58
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lenicatko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8ec167a
to
377aa5a
Compare
377aa5a
to
874d16a
Compare
index.md
Outdated
@@ -38,7 +38,7 @@ Join #crio on [Kubernetes Slack](https://slack.k8s.io/) | |||
To install on the following operating systems, set the environment variable `$OS` as the appropriate field in the following table: | |||
|
|||
| Operating system | $OS | | |||
| ---------------- | ----------------- | | |||
|------------------|-------------------| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making this change caused the table to highlight every other row. That's fine, but the backticks also do that too, and you end up with a double highlight, that IMO looks a bit wonky. I'd vote to use one of these changes, the backticks of the OS names, or this change, but not both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I opened it with ./script/server, the formatting was the same as before after this change, so I was not aware of this issue with highlighting every other row. I can return it back, as I agree, double highlighting would look strange, I am just confused why I can't see this when opening it locally.
6b963a8
to
586f6ad
Compare
I didn't notice, I will rebase. |
Signed-off-by: Lenka Bocincova <[email protected]>
586f6ad
to
2c8e3e2
Compare
2ad728b
to
9ba5dcc
Compare
67b944b
to
340f3d9
Compare
Signed-off-by: Lenka Bocincova <[email protected]>
340f3d9
to
fe6652e
Compare
Added purpose of different comms channels, link to contributing.md, added link to additional resources from Awesome CRI-O.