Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkg): rescope package names #87

Merged
merged 1 commit into from
Jan 1, 2025
Merged

feat(pkg): rescope package names #87

merged 1 commit into from
Jan 1, 2025

Conversation

crherman7
Copy link
Owner

@crherman7 crherman7 commented Dec 31, 2024

Scope

closes TICKET-86

Implementation

Rescope packages to @rechunk namespace.

Screenshots

ios

Simulator Screenshot - iPhone 15 - 2025-01-01 at 15 44 58

android

Screenshot_1735764469

How to Test

./scripts/init-local

Emoji Guide

For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.

E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.

🟢 Nice refactor!

🟡 Why was the default value removed?

E.g: Blocking feedback must be addressed before merging.

🔴 This change will break something important

Blocking 🔴 ❌ 🚨 RED
Non-blocking 🟡 💡 🤔 💭 Yellow, thinking, etc
Praise 🟢 💚 😍 👍 🙌 Green, hearts, positive emojis, etc

@crherman7 crherman7 marked this pull request as draft December 31, 2024 22:22
@@ -1,5 +1,5 @@
const path = require('path');
const {cacheVersion} = require('@crherman7/rechunk-babel-plugin');
const {cacheVersion} = require('@rechunk/babel-plugin');
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be migrated to @rechunk/metro-config

@crherman7 crherman7 marked this pull request as ready for review January 1, 2025 20:48
@crherman7 crherman7 merged commit a227b09 into develop Jan 1, 2025
@crherman7 crherman7 deleted the feat/pkg-rescope branch January 1, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant