Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase threshold of panic for negative amtInDiff #213

Closed
wants to merge 1 commit into from
Closed

fix: increase threshold of panic for negative amtInDiff #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions x/amm/keeper/pool_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,3 +245,20 @@ func (s *KeeperTestSuite) TestPoolOrderMaxOrderPriceRatio() {
s.AssertEqual(utils.ParseDec("90"), s.keeper.MustGetPoolState(s.Ctx, pool.Id).CurrentPrice)
s.AssertEqual(utils.ParseDec("90"), *s.App.ExchangeKeeper.MustGetMarketState(s.Ctx, market.Id).LastPrice)
}

func (s *KeeperTestSuite) TestPoolOrdersEdgecase2() {
market, pool := s.CreateMarketAndPool("ucre", "uusd", utils.ParseDec("0.013250000014384006"))
pool.TickSpacing = 10
s.keeper.SetPool(s.Ctx, pool)

lpAddr := s.FundedAccount(1, enoughCoins)
s.MakeLastPrice(market.Id, lpAddr, utils.ParseDec("0.01325"))
s.AddLiquidityByLiquidity(lpAddr, pool.Id, utils.ParseDec("0.000000000000010000"), utils.ParseDec("10000000000000000000000000000000000000000.000000000000000000"), sdk.NewInt(14102128091))
s.AddLiquidityByLiquidity(lpAddr, pool.Id, utils.ParseDec("0.013240000000000000"), utils.ParseDec("0.016190000000000000"), sdk.NewInt(7124428357))
s.AddLiquidityByLiquidity(lpAddr, pool.Id, utils.ParseDec("0.013240000000000000"), utils.ParseDec("0.013260000000000000"), sdk.NewInt(15106033123))
s.AddLiquidityByLiquidity(lpAddr, pool.Id, utils.ParseDec("0.013250000000000000"), utils.ParseDec("0.013260000000000000"), sdk.NewInt(30521055959))
s.AddLiquidityByLiquidity(lpAddr, pool.Id, utils.ParseDec("0.011920000000000000"), utils.ParseDec("0.014580000000000000"), sdk.NewInt(6561227654))

// Should not panic
s.PlaceMarketOrder(market.Id, lpAddr, false, sdk.NewDec(346))
}
5 changes: 2 additions & 3 deletions x/amm/keeper/source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (
)

var _ exchangetypes.OrderSource = OrderSource{}
var threshold = sdk.NewDecWithPrec(1, 16) // XXX

type OrderSource struct {
Keeper
Expand Down Expand Up @@ -199,8 +198,8 @@ func (k Keeper) AfterPoolOrdersExecuted(ctx sdk.Context, pool types.Pool, result
} else {
extraAmt1 = extraAmt1.Add(amtInDiff)
}
} else if amtInDiff.IsNegative() { // sanity check
if result.ExecutedQuantity().GT(threshold) {
} else if amtInDiff.IsNegative() {
if amtInDiff.Abs().GT(utils.OneDec) { // sanity check
panic(fmt.Sprintf("amtInDiff is negative: %s", amtInDiff))
}
}
Expand Down
Loading