Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade astro to 5.0.3 version #834

Closed

feat: deno adapter changes

a2b3310
Select commit
Loading
Failed to load commit list.
Closed

chore: upgrade astro to 5.0.3 version #834

feat: deno adapter changes
a2b3310
Select commit
Loading
Failed to load commit list.
DCO-2 / DCO required action Dec 10, 2024 in 1s

Check failed

There is one commit incorrectly signed off, the check did not pass.

Summary


Sha Message Pass or fail reason
🟢 512992b chore: upgrade astro to 5.0.3 version Valid sign-off found
🟢 e2613b0 chore: upgrade astro to 4.16.17 version Valid sign-off found
🟢 d99da6b chore: upgrade astro to 4.16.17 version Valid sign-off found
🟢 f7cb055 chore: upgrade astro to 4.16.17 version Valid sign-off found
🟢 e0de8d4 chore: astro upgarde Valid sign-off found
🟢 7ade703 chore: astro upgarde Valid sign-off found
🟢 a761bb1 chore: astro upgarde Valid sign-off found
🟢 a28d0ee fix: astro dependencies Valid sign-off found
🟢 ce9f7e6 fix: astro dependencies upgrade Valid sign-off found
🟢 c6d5a07 fix: astro dependencies upgrade Valid sign-off found
🔴 56d7aeb uninstall starlight and shiki packages Sign-off not found
🟢 a2b3310 feat: deno adapter changes Valid sign-off found

Errors details

Sign-off not found

No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.

To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <[email protected]> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

How to fix missing or invalid sign-offs

Option 1: add remediation commit

Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.

Option 2: fix commits without sign-off

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

Warning

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~12 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin chore/upgrade-astro-to-stable-version