Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/bottom bar design #165

Merged
merged 18 commits into from
Dec 15, 2023
Merged

Enhancement/bottom bar design #165

merged 18 commits into from
Dec 15, 2023

Conversation

poonam-ghewande
Copy link
Contributor

Summary

Update bottom tab bar on home page

Issue ticket number and link

#156

Checklist before requesting a review

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this).
  • Self-review of code & No unnecessary commented-out code.
  • All existing functionality remain intact.
  • Updated the README if necessary..
  • No hard-coded sensitive information.

@poonam-ghewande poonam-ghewande self-assigned this Dec 14, 2023
@poonam-ghewande poonam-ghewande force-pushed the enhancement/bottom-bar-design branch from 3521cbf to 5f143cb Compare December 14, 2023 13:27
poonam-ghewande and others added 15 commits December 14, 2023 18:58
@poonam-ghewande
fix: close contact modal after deletion (#141)
d10f098 
Signed-off-by: Poonam Ghewande <[email protected]>
@sairanjit @poonam-ghewande
fix: import wallet failure scenario (#142)
40b212f 
* fix: import wallet failure scenario

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* fix: connection already exists

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: bump ios version

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
@sairanjit @poonam-ghewande
fix: scanning qrcode multiple times (#143)
4ef4e61 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
@poonam-ghewande @sairanjit
feat/social-share certificate (#144)
454080a 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
@sairanjit @poonam-ghewande
feat: deeplink with universal link (#145)
4fda0a1 
* feat: add agent link as deep link

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: bump iOS version

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
@sairanjit @poonam-ghewande
fix deep link issue (#147)
0c6d414 
* feat: add agent link as deep link

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: bump iOS version

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: bump versions

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
@sairanjit @poonam-ghewande
feat: add remote verification templates (#148)
426bfdf 
* feat: add remote verification templates

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: bump versions

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* fix: verifier capability for previous version

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
@poonam-ghewande
fix: close contact modal after deletion (#141)
1cbd0ba 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
@poonam-ghewande @sairanjit
feat/social-share certificate (#144)
e5027bb 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
@poonam-ghewande @sairanjit
refactor: update exporeIcon on bottom tab-bar (#149)
cdedc1f 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
@sairanjit @poonam-ghewande
fix: credential detail modal button container (#155)
d74858c 
Signed-off-by: Poonam Ghewande <[email protected]>
@poonam-ghewande
Fix/remove contact (#160)
25d6f63 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)

Signed-off-by: Poonam Ghewande <[email protected]>
@poonam-ghewande @sairanjit
Style/UI update (#163)
a553ea7 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
@poonam-ghewande @sairanjit
Fix/bug biometric enable pin enter (#164)
edf020b 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
@poonam-ghewande
chore:modified bottom tab bar ui
90141dc 
Signed-off-by: Poonam Ghewande <[email protected]>
@poonam-ghewande poonam-ghewande force-pushed the enhancement/bottom-bar-design branch from 5f143cb to 90141dc Compare December 14, 2023 13:29
sairanjit
sairanjit requested changes Dec 15, 2023
View reviewed changes
app/theme.ts Outdated Show resolved Hide resolved
app/theme.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

11 New issues
0 Security Hotspots
No data about Coverage
2.4% Duplication on New Code

See analysis details on SonarCloud

sairanjit
sairanjit approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@sairanjit sairanjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sairanjit sairanjit merged commit 3cb958d into dev Dec 15, 2023
2 checks passed
@sairanjit sairanjit deleted the enhancement/bottom-bar-design branch December 15, 2023 06:47
@poonam-ghewande poonam-ghewande linked an issue Dec 15, 2023 that may be closed by this pull request
ADEYA UI enhancement #156
Open
4 tasks
poonam-ghewande added a commit that referenced this pull request Dec 18, 2023
@poonam-ghewande @sairanjit
refactor: enhance bottom bar design (#165)
f43ae6c 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 18, 2023
@poonam-ghewande @sairanjit
refactor: enhance bottom bar design (#165)
eb82c24 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
@sairanjit sairanjit restored the enhancement/bottom-bar-design branch February 27, 2024 07:29
sairanjit added a commit that referenced this pull request Feb 27, 2024
@sairanjit
Revert "refactor: enhance bottom bar design (#165)"
e31a4c1 
This reverts commit 3cb958d.
@sairanjit sairanjit mentioned this pull request Feb 27, 2024
Merged
sairanjit added a commit that referenced this pull request Feb 27, 2024
@sairanjit
Revert "refactor: enhance bottom bar design (#165)"
4538a53 
This reverts commit 3cb958d.

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit added a commit that referenced this pull request Apr 15, 2024
@poonam-ghewande @sairanjit
refactor: enhance bottom bar design (#165)
4152147 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit added a commit that referenced this pull request Apr 15, 2024
@poonam-ghewande @sairanjit
refactor: enhance bottom bar design (#165)
5705ddc 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit added a commit that referenced this pull request Apr 15, 2024
@poonam-ghewande @sairanjit
refactor: enhance bottom bar design (#165)
eb2ec6c 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande @sairanjit
refactor: enhance bottom bar design (#165)
4141642 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande @sairanjit
refactor: enhance bottom bar design (#165)
24283fe 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande @sairanjit
refactor: enhance bottom bar design (#165)
faf2fe1 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande @sairanjit
refactor: enhance bottom bar design (#165)
633f35f 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande @sairanjit
refactor: enhance bottom bar design (#165)
db77a7d 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
sairanjit added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande @sairanjit
refactor: enhance bottom bar design (#165)
ef58219 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande @sairanjit
refactor: enhance bottom bar design (#165)
0014337 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
@sairanjit sairanjit deleted the enhancement/bottom-bar-design branch September 2, 2024 07:02
sairanjit added a commit that referenced this pull request Sep 5, 2024
@poonam-ghewande @sairanjit
refactor: enhance bottom bar design (#165)
bcb7802 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sairanjit sairanjit sairanjit approved these changes

Assignees

@poonam-ghewande poonam-ghewande

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ADEYA UI enhancement
2 participants
@poonam-ghewande @sairanjit