-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a FIFO/LIFO IRedeemOptimizer
realisation.
#123
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiTokenVault` realises the desired function. May be reverted.
…ed optimisation strategy.
Add a FIFO/LIFO
|
Severity Level | Results | |
---|---|---|
Contracts | Critical High Medium Low Note Total |
1 0 0 4 22 27 |
Dependencies | Critical High Medium Low Note Total |
0 0 0 0 0 0 |
For more details view the full report in OpenZeppelin Code Inspector
jplodge-pro
commented
Oct 7, 2024
jplodge-pro
commented
Oct 7, 2024
packages/contracts/src/token/ERC1155/RedeemOptimizerFIFOLIFO.sol
Outdated
Show resolved
Hide resolved
jplodge-pro
commented
Oct 7, 2024
to get total amount requested for unlock by requestId
Removed all logging. Added some natspec and TODO/NOTEs Initial test for FIFOLIFO optimizer, entirely derivative of the FIFO tests.
Extended it in the realisations. Split the tests in a similar way. TODO: realisation tests to extend
4 tasks
Replaced with #128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
As discussed with @lucasia thus:
To Do
IRedeemOptimizer
that encapsulates the above strategy.RedeemOptimizer
base realisation to encapsulate common behaviours.IMultiTokenVault
to include theERC1155Supply
exists(uint256 id)
, because:IRedeemOptimizer
to seamlessly track the first period that has any deposits against it. This is the typical starting point of optimisation.