Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use qemu-guest-agent on macos #914

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Only use qemu-guest-agent on macos #914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions qemu-guest-agent.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[Unit]
Description=QEMU Guest Agent
IgnoreOnIsolate=True
ConditionVirtualization=apple
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per man systemd.unit looks like this is added in v244, and current used version in OCP is 252 which is good for this usecase.

      ConditionVirtualization=
           Check whether the system is executed in a virtualized environment and optionally test whether it is a specific
           implementation. Takes either boolean value to check if being executed in any virtualized environment, or one of
           "vm" and "container" to test against a generic type of virtualization solution, or one of "qemu", "kvm",
           "amazon", "zvm", "vmware", "microsoft", "oracle", "powervm", "xen", "bochs", "uml", "bhyve", "qnx", "apple",
           "sre", "openvz", "lxc", "lxc-libvirt", "systemd-nspawn", "docker", "podman", "rkt", "wsl", "proot", "pouch",
           "acrn" to test against a specific implementation, or "private-users" to check whether we are running in a user
           namespace. See systemd-detect-virt(1) for a full list of known virtualization technologies and their
           identifiers. If multiple virtualization technologies are nested, only the innermost is considered. The test may
           be negated by prepending an exclamation mark.

           Added in version 244.


[Service]
UMask=0077
Expand Down