-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QE] fix linux e2e failure of podman #4436
Conversation
a9c110c
to
e0f4665
Compare
@adrianriobo Could you review this pr? |
|
8fdefe8
to
13759cd
Compare
fmt.Println(err) | ||
os.Exit(1) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you really doesn't need to use platform (linux) condition here because when you unset the network-mode property it would go to default which is for linux => system-mode and for other platform user mode.
So only following should work.
err = crcCmd.UnsetConfigPropertySucceedsOrFails("network-mode", "succeeds") // unsetting property that is not set gives 0 exitcode, so this works
if err != nil {
fmt.Println(err)
os.Exit(1)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@praveenkumar I didn't add the platform condition at the beginning, but the check on Windows failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unset command will fail on both windows and mac platform.
Check in windows:
PS C:\Users\crcqe> crc config unset network-mode
Configuration property 'network-mode' does not exist
PS C:\Users\crcqe> echo $?
False
Check in mac:
lul@lul-mac hosts % crc config unset network-mode
Configuration property 'network-mode' does not exist
lul@lul-mac hosts % echo $?
1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah network-mode
is added for linux only :(
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anjannath, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lilyLuLiu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes: Issue #4424