Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QE] fix linux e2e failure of podman #4436

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

lilyLuLiu
Copy link
Contributor

Fixes: Issue #4424

@lilyLuLiu lilyLuLiu changed the title [QE] fix linux e2e failure of podman, issue 4424 [QE] fix linux e2e failure of podman Nov 7, 2024
@lilyLuLiu lilyLuLiu force-pushed the issue4424 branch 5 times, most recently from a9c110c to e0f4665 Compare November 12, 2024 07:52
@lilyLuLiu
Copy link
Contributor Author

@adrianriobo Could you review this pr?

@anjannath
Copy link
Member

e2e-crc failure is about cert rotation scenario and integration-crc failure is related to the proxy scenario, both are known failures

fmt.Println(err)
os.Exit(1)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you really doesn't need to use platform (linux) condition here because when you unset the network-mode property it would go to default which is for linux => system-mode and for other platform user mode.

So only following should work.

err = crcCmd.UnsetConfigPropertySucceedsOrFails("network-mode", "succeeds") // unsetting property that is not set gives 0 exitcode, so this works
					if err != nil {
						fmt.Println(err)
						os.Exit(1)
					}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@praveenkumar I didn't add the platform condition at the beginning, but the check on Windows failed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unset command will fail on both windows and mac platform.
Check in windows:

PS C:\Users\crcqe> crc config unset network-mode
Configuration property 'network-mode' does not exist
PS C:\Users\crcqe> echo $?
False

Check in mac:

lul@lul-mac hosts % crc config unset network-mode
Configuration property 'network-mode' does not exist
lul@lul-mac hosts % echo $?
1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah network-mode is added for linux only :(

Copy link

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anjannath, praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Nov 19, 2024

@lilyLuLiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-crc d3a9fc7 link true /test integration-crc
ci/prow/e2e-crc d3a9fc7 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@praveenkumar praveenkumar merged commit 7664059 into crc-org:main Nov 19, 2024
27 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants