Fix help.github.com link checks #3155
Conversation
In the next commit, we will add additional config entries unrelated to the ignorelist we currently have.
|
Why no github action run on this PR? |
For some reason, help.github.com will only serve compressed content, and will reply with a 403 error without any "Accept-encoding" headers. This causes 'make docs_check_links' to report help.github.com links as being dead. This is tracked in github/docs#17358 For this fix to work, quay.io/crcont/docs-builder:latest must be rebuilt and pushed to quay. This can be rebuilt and tested locally with: $ (cd images/docs-builder && podman build -t quay.io/crcont/docs-builder:latest .) $ make docs_check_links
cfergeau
force-pushed
the
asciidoc-link-check
branch
from
5b415a1 to
1ac7b33
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Maybe because it was initially based on |
|
(NB: the "build and publish docs" failure is expected as the quay.io docs-build image hasn't been updated yet with the changes from this PR) |
|
@cfergeau: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I've pushed the quay.io/crcont/docs-build image with the changes from this PR to quay.io, this should fix docs link checks for this PR and also for the other PRs. |
For some reason, help.github.com will only serve compressed content, and
will reply with a 403 error without any "Accept-encoding" headers.
This causes 'make docs_check_links' to report help.github.com links as being
dead.
This issue is tracked in github/docs#17358
For this fix to work, quay.io/crcont/docs-builder:latest must be rebuilt
and pushed to quay.
This can be rebuilt and tested locally with:
$ (cd images/docs-builder && podman build -t quay.io/crcont/docs-builder:latest .)
$ make docs_check_links