Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rTorrent v5.3 #377

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Upgrade to rTorrent v5.3 #377

merged 1 commit into from
Jul 14, 2024

Conversation

stickz
Copy link
Contributor

@stickz stickz commented Jul 14, 2024

The full changelog between the last tag can be viewed here.
Full Changelog: stickz/rtorrent@v5.1-0.9.8-0.13.8...v5.3-0.9.8-0.13.8

Version 5.3 Release

The --disable-instrumentation configure option for libtorrent now it's works properly. The threads still have instrumentation, so they work properly. All other source code instrumentation is disabled at compile time. This allows the software to perform tasks in the most efficient order and reduces scheduling overhead.

This configure option is an intermediary step. It's highly recommended to use it. In the future, instrumentation will be removed entirely for non-threaded tasks. In the very unlikely event a regression is found, please file an issue report.

What's Changed

Full Changelog: stickz/rtorrent@v5.2-0.9.8-0.13.8...v5.3-0.9.8-0.13.8

Version 5.2 Release

It is highly recommended to upgrade to this release. The fallocate feature works better. A critical software crash is also resolved.

  1. Removes ~1100 lines of unused code from the project.
  2. Removes --with-posix-fallocate libtorrent configure option in favour of automation.
  3. Optimizes the fallocate feature to perform less redundant tasks at runtime.
  4. Fixes a critical software crash with various methods inputted into .rtorrent.rc.

What's Changed

Full Changelog: stickz/rtorrent@v5.1-0.9.8-0.13.8...v5.2-0.9.8-0.13.8

@stickz stickz requested a review from crazy-max as a code owner July 14, 2024 16:48
@stickz
Copy link
Contributor Author

stickz commented Jul 14, 2024

@crazy-max There are some changes to the way the software works. A crash that impacts this docker container is also resolved. It's recommended to tag a new release after merging. There were too many changes from v4.0 to v5.3 hence the v5.1 tag.

  1. The --with-posix-fallocate fallocate configure option is now removed. When configuring and building, the software will automatically enable posix-fallocate if fallocate is not supported. This reduces runtime overhead and simplifies builds.

  2. The --disable-instrumentation feature is now fixed and works properly. The software will perform tasks in the most efficient order and have less scheduling overhead without instrumentation. It's now only used where required for threaded tasks. This instrumentation code will be removed in the future. It's stable and we should use it now.

  3. A software crash impacting this docker container is resolved. There's a setting we inputted into .rtorrent.rc which may cause a crash under limited circumstances. This issue is now fixed from the software standpoint.

Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thx

@crazy-max crazy-max merged commit 1539658 into crazy-max:master Jul 14, 2024
7 checks passed
@stickz stickz deleted the patch-14 branch July 20, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants