Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rTorrent: Upgrade to v3.2 #357

Merged
merged 1 commit into from
Jun 2, 2024
Merged

rTorrent: Upgrade to v3.2 #357

merged 1 commit into from
Jun 2, 2024

Conversation

stickz
Copy link
Contributor

@stickz stickz commented Jun 2, 2024

Version 3.2 hotfix

  • This hotfix resolves a critical issue with flushing invalid bencode to disk.
  • It also optimizes writing bencode to disk. Metadata is now only flushed when required.

What's Changed

Full Changelog: stickz/rtorrent@v3.1-0.9.8-0.13.8...v3.2-0.9.8-0.13.8

# Version 3.2 hotfix
- This hotfix resolves a critical issue with flushing invalid bencode to disk. 
- It also optimizes writing bencode to disk. Metadata is now only flushed when required.

## What's Changed
* rTorrent: Fix & optimize write_bencode by @stickz in stickz/rtorrent@970deae

**Full Changelog**: stickz/rtorrent@v3.1-0.9.8-0.13.8...v3.2-0.9.8-0.13.8
@stickz stickz requested a review from crazy-max as a code owner June 2, 2024 13:51
@stickz
Copy link
Contributor Author

stickz commented Jun 2, 2024

Addresses #281 (comment) and #332 (comment).

@AntAreS24 I found a scenario where invalid bencode could be written to disk.
@ewenjo I optimized writing bencode to disk. It will skip flushing metadata now when not required for a speedup.

Please feel free to test once merged.

Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crazy-max crazy-max merged commit 0d3ade3 into crazy-max:master Jun 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants