rTorrent: Resolve memory access crash #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rTorrent requires the usage of aligned memory access on all platforms (x86 and ARM) to prevent a memory access crash from happening. As such, we need to configure libtorrent with `--enable-aligned` to enable the feature. This is also more efficient for CPU usage at the cost of slightly more memory consumption. However, due to the relatively small usage of memory, all platforms will benefit. More information can be found here: rakshasa/libtorrent#244
3 tasks
|
@crazy-max There has been an issue opened #315 about rTorrent segmentation faults during hash checking. This PR might resolve that problem. Could we get this pushed to docker edge, so the user can confirm a resolution or continue testing? |
crazy-max
approved these changes
Jan 16, 2024
XxAcielxX
added a commit
to XxAcielxX/docker-rutorrent
that referenced
this pull request
Apr 28, 2024
## Changes: * Update to `ruTorrent v4.3.0` ## Base Image: * rTorrent: Add TCP socket configurations ([322](crazy-max/docker-rtorrent-rutorrent#322)) * Add php82-fileinfo package ([325](crazy-max/docker-rtorrent-rutorrent#325)) * rTorrent: Set of patches to fix memory leaks ([308](crazy-max/docker-rtorrent-rutorrent#308)) * rTorrent: Fix memory access crash ([310](crazy-max/docker-rtorrent-rutorrent#310))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rTorrent requires the usage of aligned memory access on all platforms (x86 and ARM) to prevent a memory access crash from happening. As such, we need to configure libtorrent with
--enable-alignedto enable the feature.This is also more efficient for CPU usage at the cost of slightly more memory consumption. However, due to the relatively small usage of memory, all platforms will benefit.
More information can be found here: rakshasa/libtorrent#244