Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve c-ares & curl build process #295

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

stickz
Copy link
Contributor

@stickz stickz commented Dec 22, 2023

This commit improves the c-ares and curl build process to use cmake instead. This is a much better choice for docker container. We do not require the features GNU Make provides. CMake should also be more stable for testing pull requests on GitHub.

It also upgrades the c-ares and curl version to receive the latest bug fixes and performance changes. There's been a huge leap forward since the older changes. Put simple, curl 8 is faster. https://daniel.haxx.se/blog/2023/04/28/curl-8-is-faster/

This commit improves the c-ares and curl build process to use cmake instead. This is a much better choice for docker container. We do not require the features GNU Make provides. CMake should also be more stable for testing pull requests on GitHub.

It also upgrades the c-ares and curl version to receive the latest bug fixes and performance changes. There's been a huge leap forward since the older changes. Put simple, curl 8 is faster.
@stickz stickz requested a review from crazy-max as a code owner December 22, 2023 20:15
@stickz
Copy link
Contributor Author

stickz commented Dec 22, 2023

AMD64 job completed in 5m instead of 7m. This is from the build log showing the new version of curl is working properly.

#102 8.742 curl 8.5.0 (Linux) libcurl/8.5.0 OpenSSL/3.1.4 zlib/1.2.13 brotli/1.0.9 zstd/1.5.5 c-ares/1.24.0
#102 8.742 Release-Date: 2023-12-06
#102 8.742 Protocols: dict file ftp ftps gopher gophers http https imap imaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
#102 8.742 Features: alt-svc AsynchDNS brotli HSTS HTTPS-proxy IPv6 Largefile libz NTLM SSL threadsafe TLS-SRP UnixSockets zstd

We will get results from ARM when it completes in 45m instead of 55m. 👍

@stickz
Copy link
Contributor Author

stickz commented Dec 22, 2023

This is from ARMv6. All the ARM containers have the same results. It completed in 42m down from 56m.

#102 38.54 curl 8.5.0 (Linux) libcurl/8.5.0 OpenSSL/3.1.4 zlib/1.2.13 brotli/1.0.9 zstd/1.5.5 c-ares/1.24.0
#102 38.54 Release-Date: 2023-12-06
#102 38.54 Protocols: dict file ftp ftps gopher gophers http https imap imaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
#102 38.54 Features: alt-svc AsynchDNS brotli HSTS HTTPS-proxy IPv6 Largefile libz NTLM SSL threadsafe TLS-SRP UnixSockets zstd

Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@crazy-max crazy-max merged commit e7faf4f into crazy-max:master Dec 22, 2023
7 checks passed
@stickz stickz deleted the curl-upgrade branch December 24, 2023 00:17
XxAcielxX added a commit to XxAcielxX/docker-rutorrent that referenced this pull request Dec 28, 2023
## Base Image:
* rTorrent: tracker scrape feature patch
([288](crazy-max/docker-rtorrent-rutorrent#288))
* Alpine Linux 3.19 and PHP 8.2
([297](crazy-max/docker-rtorrent-rutorrent#297))
* cURL 8.5.0, c-ares 1.24.0
([295](crazy-max/docker-rtorrent-rutorrent#295))
* UDNS support
([303](crazy-max/docker-rtorrent-rutorrent#303))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants