-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker image building improvements #292
Conversation
0c7cad3
to
0963816
Compare
@crazy-max I was unable to test my changes in #291 due to GitHub Actions time-outs. So I made you a brand new workflow for GitHub pull requests, built c-ares and curl with cmake and disabled gcc warnings during build for some software. |
0963816
to
8654518
Compare
b1afcd0
to
764d11b
Compare
97e5f9f
to
e9dbde3
Compare
e9dbde3
to
4137cf7
Compare
Sorry about all that building. When I separated the tasks and silenced warnings, I saw the rTorrent software stack was not building with the intended flags. Everything is fixed now. We have 5m feedback for x86 and 40m feedback for ARM. The build process for ARM has also been significantly optimized to cut down on time. There is less verbose and c-ares + curl is built with a much more efficient cmake process. These changes will make it much easier to develop/maintain the docker container. Everything is working fast and flawlessly now. |
- '**.md' | ||
|
||
jobs: | ||
build_amd64: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make some changes to distribute builds across runners. I already done this in https://github.com/crazy-max/docker-linguist/blob/master/.github/workflows/build.yml based on a guide I made: https://docs.docker.com/build/ci/github-actions/multi-platform/#distribute-build-across-multiple-runners
I keep you posted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I will submit a new pull request in 15 minutes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should resolve timeout problems for PRs.