Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image building improvements #292

Closed
wants to merge 1 commit into from

Conversation

stickz
Copy link
Contributor

@stickz stickz commented Dec 21, 2023

  1. Instead of building all the platforms at once, build them as a separate jobs.
  2. Build c-ares and curl with cmake to significantly speed along the build process.
  3. Disable build warnings for xmlrpc, libtorrent and rtorrent to speed along the build process.
  4. Fixed a critical issue where xmlrpc and libtorrent was not being built with the intended flags.

This should resolve timeout problems for PRs.

@stickz
Copy link
Contributor Author

stickz commented Dec 21, 2023

@crazy-max I was unable to test my changes in #291 due to GitHub Actions time-outs. So I made you a brand new workflow for GitHub pull requests, built c-ares and curl with cmake and disabled gcc warnings during build for some software.

@stickz stickz changed the title GitHub: Setup new jobs for pull requests GitHub: Setup AMD64 & ARM jobs Dec 21, 2023
@stickz stickz force-pushed the github-actions branch 2 times, most recently from b1afcd0 to 764d11b Compare December 21, 2023 20:03
@stickz stickz changed the title GitHub: Setup AMD64 & ARM jobs Docker image building improvements Dec 21, 2023
@stickz stickz force-pushed the github-actions branch 6 times, most recently from 97e5f9f to e9dbde3 Compare December 21, 2023 21:28
@stickz
Copy link
Contributor Author

stickz commented Dec 21, 2023

Sorry about all that building. When I separated the tasks and silenced warnings, I saw the rTorrent software stack was not building with the intended flags. Everything is fixed now. We have 5m feedback for x86 and 40m feedback for ARM.

The build process for ARM has also been significantly optimized to cut down on time. There is less verbose and c-ares + curl is built with a much more efficient cmake process.

These changes will make it much easier to develop/maintain the docker container. Everything is working fast and flawlessly now.

- '**.md'

jobs:
build_amd64:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make some changes to distribute builds across runners. I already done this in https://github.com/crazy-max/docker-linguist/blob/master/.github/workflows/build.yml based on a guide I made: https://docs.docker.com/build/ci/github-actions/multi-platform/#distribute-build-across-multiple-runners

I keep you posted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will submit a new pull request in 15 minutes!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged #293 and opened #294 as follow-up to fix some issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants