Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rTorrent: Add stability patches #286

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

stickz
Copy link
Contributor

@stickz stickz commented Dec 5, 2023

This commit adds multiple stability patches to rtorrent. I have tested these for multiple months. The reason for modifying the software is to resolve stability issues. The software owner is no longer releasing new versions.

libtorrent

  • Fixes an issue where the throttle plugin on ruTorrent is required to limit upload/download speed to 1gbps.

rTorrent

  • Fixes a crash caused by some hardening flags during the build process.
  • Fixes a crash caused by ruTorrent sending invalid xmlrpc data to rTorrent.
  • Fixes a crash caused by external configurations sending invalid xmlrpc data to rTorrent.
  • Fixes an issue where torrent information will not update if too many torrents are running.
  • Fixes an issue where a power loss during torrent session saving will corrupt torrents.

@stickz stickz requested a review from crazy-max as a code owner December 5, 2023 16:47
@stickz
Copy link
Contributor Author

stickz commented Dec 5, 2023

@crazy-max I can see from the build log these patches installed successfully and the build passed. I do not have a configuration to build this docker image. The only step required to build the docker image and ensure rTorrent runs properly before pushing changes. I have tested these changes for months. There should be zero issues and significantly improved rTorrent stability.

Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM thanks

I saw your upstream changes https://github.com/rakshasa/rtorrent/pulls/stickz, hopefully it will be considered in the future. The rotrrent/libtorrent projects look active but yeah without tags we can't expect proper stability.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
This commit adds multiple stability patches to rtorrent.
@stickz
Copy link
Contributor Author

stickz commented Dec 14, 2023

Overall LGTM thanks

All fixed up. Suggestions implemented.

@stickz stickz requested a review from crazy-max December 14, 2023 21:27
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks again!

@crazy-max crazy-max merged commit f895540 into crazy-max:master Dec 14, 2023
2 checks passed
@crazy-max
Copy link
Owner

Small nit as follow-up would be to update this section in the README: https://github.com/crazy-max/docker-rtorrent-rutorrent#features about Latest rTorrent / libTorrent release compiled from source to say some patches are also applied to enhance rTorrent stability or smth like that.

@stickz stickz deleted the rtorrent-patches branch December 14, 2023 21:38
@stickz
Copy link
Contributor Author

stickz commented Dec 14, 2023

Small nit as follow-up would be to update this section in the README: https://github.com/crazy-max/docker-rtorrent-rutorrent#features about Latest rTorrent / libTorrent release compiled from source to say some patches are also applied to enhance rTorrent stability or smth like that.

I will update that next pull request when 10gbps throttle support is added. This container will be the first to support 10gbps by default on ruTorrent with throttling capabilities. This will bring the configuration into the next decade!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants