-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rTorrent: Add stability patches #286
Conversation
@crazy-max I can see from the build log these patches installed successfully and the build passed. I do not have a configuration to build this docker image. The only step required to build the docker image and ensure rTorrent runs properly before pushing changes. I have tested these changes for months. There should be zero issues and significantly improved rTorrent stability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM thanks
I saw your upstream changes https://github.com/rakshasa/rtorrent/pulls/stickz, hopefully it will be considered in the future. The rotrrent/libtorrent projects look active but yeah without tags we can't expect proper stability.
This commit adds multiple stability patches to rtorrent.
6a3bcdb
to
951530e
Compare
All fixed up. Suggestions implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks again!
Small nit as follow-up would be to update this section in the README: https://github.com/crazy-max/docker-rtorrent-rutorrent#features about |
I will update that next pull request when 10gbps throttle support is added. This container will be the first to support 10gbps by default on ruTorrent with throttling capabilities. This will bring the configuration into the next decade! |
This commit adds multiple stability patches to rtorrent. I have tested these for multiple months. The reason for modifying the software is to resolve stability issues. The software owner is no longer releasing new versions.
libtorrent
rTorrent