refactor: Update SendNotification function to handle old and new sett…

…ings triggers
crawlab-team · Jul 14, 2024 · e672329 · e672329
1 parent efabb20
commit e672329
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/core/grpc/server/task_server_v2.go b/core/grpc/server/task_server_v2.go
@@ -138,7 +138,14 @@ func (svr TaskServerV2) SendNotification(ctx context.Context, request *grpc.Requ
 		return nil, trace.TraceError(err)
 	}
 	for _, s := range settings {
-		switch s.TaskTrigger {
+		// compatible with old settings
+		trigger := s.Trigger
+		if trigger == "" {
+			trigger = s.TaskTrigger
+		}
+
+		// send notification
+		switch trigger {
 		case constants.NotificationTriggerTaskFinish:
 			if t.Status != constants.TaskStatusPending && t.Status != constants.TaskStatusRunning {
 				_ = svc.Send(&s, e)