feat: allow set max runners for nodes

crawlab-team · Dec 11, 2024 · 272371d · 272371d
1 parent 1fe74fa
commit 272371d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/.github/workflows/docker-crawlab.yml b/.github/workflows/docker-crawlab.yml
@@ -311,11 +311,6 @@ jobs:
         env:
           CRAWLAB_NODE_MASTER: N
           CRAWLAB_MASTER_HOST: master
-        options: >-
-          --health-cmd "curl -f http://localhost:8000/health || exit 1"
-          --health-interval 10s
-          --health-timeout 5s
-          --health-retries 10
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4

diff --git a/core/task/handler/service.go b/core/task/handler/service.go
@@ -85,8 +85,8 @@ func (svc *Service) fetchAndRunTasks() {
 				continue
 			}
 
-			// validate if there are available runners
-			if svc.getRunnerCount() >= n.MaxRunners {
+			// validate if max runners is reached (max runners = 0 means no limit)
+			if n.MaxRunners > 0 && svc.getRunnerCount() >= n.MaxRunners {
 				continue
 			}
 

diff --git a/core/utils/config.go b/core/utils/config.go
@@ -24,7 +24,7 @@ const (
 	DefaultApiAllowCredentials = "true"
 	DefaultApiAllowMethods     = "DELETE, POST, OPTIONS, GET, PUT"
 	DefaultApiAllowHeaders     = "Content-Type, Content-Length, Accept-Encoding, X-CSRF-Token, Authorization, accept, origin, Cache-Control, X-Requested-With"
-	DefaultNodeMaxRunners      = 16
+	DefaultNodeMaxRunners      = 0 // 0 means no limit
 	MetadataConfigDirName      = ".crawlab"
 	MetadataConfigName         = "config.json"
 	PyenvRoot                  = "/root/.pyenv"