Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust software tests for CrateDB #10

Merged
merged 11 commits into from
Sep 12, 2023
Merged

Adjust software tests for CrateDB #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6b23ac0
Tests: Remove tests specific to SQLite
amotl Sep 7, 2023
03a1862
Tests: Remove tests related to database migrations
amotl Sep 7, 2023
5b281b7
Tests: Add support for CrateDB
amotl Sep 7, 2023
37c7739
Tests: Skip slow or failing tests, also partly failing ones
amotl Sep 7, 2023
0f6e969
Tests: Prune tables on test setup
amotl Sep 9, 2023
f99944c
Tests: Use `get_experiment_by_name` instead of `get_experiment`
amotl Sep 9, 2023
67193dd
Tests: Compensate for experiment identifiers not being autoincrement
amotl Sep 9, 2023
961b002
Tests: Fix an upstream bug
amotl Sep 9, 2023
2583d69
Tests: Fix import error
amotl Sep 9, 2023
a40ee49
Tests: Extend `db_types_and_drivers` with CrateDB item
amotl Sep 9, 2023
f622f4b
Tests: Satisfy linter for `test_tracking.py`
amotl Sep 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion mlflow_cratedb/patch/mlflow/db_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
CRATEDB = "crate"


def patch_dbtypes():
"""
Register CrateDB as available database type.
"""
import mlflow.store.db.db_types as db_types

db_types.CRATEDB = "crate"
db_types.CRATEDB = CRATEDB

if db_types.CRATEDB not in db_types.DATABASE_ENGINES:
db_types.DATABASE_ENGINES.append(db_types.CRATEDB)
6 changes: 6 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ repository = "https://github.com/crate-workbench/mlflow-cratedb"
[tool.black]
line-length = 120

extend-exclude = "tests/test_tracking.py"

[tool.isort]
profile = "black"
skip_glob = "**/site-packages/**"
Expand Down Expand Up @@ -162,6 +164,10 @@ select = [
"RET",
]

extend-exclude = [
]


[tool.ruff.per-file-ignores]
"tests/*" = ["S101"] # Use of `assert` detected

Expand Down
3 changes: 3 additions & 0 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from mlflow_cratedb import patch_all

patch_all()
Loading