Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Add page about software testing with CrateDB (Java and Python) #80

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Feb 12, 2024

About

This patch adds a dedicated page which is indexing a few resources about software integration testing with Java and Python.

  • native: Python unittest, using cr8
  • native: pytest-crate, using cr8
  • testcontainers: Testcontainers for Java
  • testcontainers: Testcontainers for Python (pytest and unittest)

References

Preview

/cc @karynzv, @hlcianfagna, @marijaselakovic, @seut

Copy link

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, left some alternative phrasing suggestions.

docs/integrate/testing.md Outdated Show resolved Hide resolved
docs/integrate/testing.md Outdated Show resolved Hide resolved
docs/integrate/testing.md Outdated Show resolved Hide resolved
(python-unittest)=
## Python unittest

[cr8], a collection of tools for CrateDB developers, provides primitives to
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[cr8], a collection of tools for CrateDB developers, provides primitives to
[cr8], a collection of tools for CrateDB developers, provides primitive functionality, to

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to say "primitive functionality", but rather "primitive element" instead. Do you have a different suggestion?

-- https://www.techtarget.com/whatis/definition/primitive

Copy link
Member Author

@amotl amotl Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've amended the patch once more, and used "primitive elements" literally now. Maybe this causes less reading hiccups for the uninitiated?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's minor detail, no need to change. Just, for me, it would read better as basic functionality, as this: primitive elements suit better in a programming language context.

Copy link
Member Author

@amotl amotl Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point. In this case, the page about software testing probably has an audience of software developers, so I thought they would be familiar with programming language concepts and jargon.

For me, it is difficult to designate something as basic functionality, when effectively it is advanced functionality already, wrapped into a primitive interface.

Now, that we talked about our personal dilemmas in wording extensively, let's merge the PR ;].

- native: Python unittest, using cr8
- native: pytest-crate, using cr8
- testcontainers: Testcontainers for Java
- testcontainers: Testcontainers for Python (pytest and unittest)
@amotl amotl merged commit ce1763c into main Feb 14, 2024
4 checks passed
@amotl amotl deleted the amo/testing branch February 14, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants