-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Java interop PR #70
Open
kevaundray
wants to merge
5
commits into
master
Choose a base branch
from
kw/test-java-impl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
75bb37e
add small test
kevaundray ca2d05a
make it more obvious that both tests have non-canonical inputs
kevaundray ff43c01
Apply suggestions from code review
kevaundray 005eb24
Add new test file
kevaundray e0789a5
use ReadScalar
kevaundray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
package common_test | ||
|
||
import ( | ||
"bytes" | ||
"encoding/hex" | ||
"testing" | ||
|
||
"github.com/crate-crypto/go-ipa/common" | ||
) | ||
|
||
func TestJavaRegressionOneEndian(t *testing.T) { | ||
hexStr := "f6e31f7a565a390b48fdd24569ac10d43562d19de37ea951c7f9f250a339d059" | ||
byteArray := hexStrToBytes(hexStr) | ||
_scalar, err := common.ReadScalar(bytes.NewReader(byteArray)) | ||
|
||
if err == nil { | ||
t.Fatalf("expected an error because the scalar is too large") | ||
} | ||
_ = _scalar | ||
} | ||
func TestJavaRegressionOtherEndian(t *testing.T) { | ||
hexStr := "f6e31f7a565a390b48fdd24569ac10d43562d19de37ea951c7f9f250a339d059" | ||
byteArray := hexStrToBytes(hexStr) | ||
reverse(byteArray) | ||
_scalar, err := common.ReadScalar(bytes.NewReader(byteArray)) | ||
if err == nil { | ||
t.Fatalf("expected an error because the scalar is too large, even though we changed the endian") | ||
} | ||
_ = _scalar | ||
} | ||
|
||
func reverse(data []byte) { | ||
for i, j := 0, len(data)-1; i < j; i, j = i+1, j-1 { | ||
data[i], data[j] = data[j], data[i] | ||
} | ||
} | ||
|
||
func hexStrToBytes(numStr string) []byte { | ||
|
||
byteArray, err := hex.DecodeString(numStr) | ||
if err != nil { | ||
panic(err) | ||
} | ||
return byteArray | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the failing tests