Test new pr review #46

2bndy5 · 2024-12-20T18:24:22Z

No description provided.

github-actions · 2024-12-20T18:25:47Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v17.0.4) reports: 2 file(s) not formatted

src/demo.cpp
src/demo.hpp

clang-tidy (v17.0.4) reports: 6 concern(s)

src/demo.cpp:2:1: warning: [misc-include-cleaner]

included header demo.hpp is not used directly

    2 | #include "demo.hpp"
      | ^~~~~~~~~~~~~~~~~~~
    3 | #include <stdio.h>

src/demo.cpp:3:10: warning: [modernize-deprecated-headers]

inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead
```
    3 | #include <stdio.h>
      |          ^~~~~~~~~
      |          <cstdio>
```
src/demo.cpp:8:5: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
    8 | int main(){
      | ~~~ ^     
      | auto       -> int
```
src/demo.cpp:10:13: warning: [readability-braces-around-statements]

statement should be inside braces
```
   10 |     for (;;) break;
      |             ^      
      |              {
```
src/demo.cpp:13:5: warning: [cppcoreguidelines-pro-type-vararg]

do not call c-style vararg functions
```
   13 |     printf("Hello world!\n");
      |     ^
```

src/demo.hpp:11:11: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function

   11 |     void *not_useful(char *str){useless = str;}
      |     ~~~~~~^                    
      |     auto                        -> void *

Have any feedback or feature suggestions? Share it here.

Outdated review

github-actions

Cpp-Linter Review

Used clang-tidy v17.0.4

Click here for the full clang-tidy patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 1bf553e..8caf462 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -2,2 +2 @@
-#include "demo.hpp"
-#include <stdio.h>
+#include <cstdio>
@@ -4,0 +4,2 @@
+auto main() -> int
+{
@@ -6,6 +7,3 @@
-
-
-int main(){
-
-    for (;;) break;
-
+    for (;;) {
+        break;
+    }
@@ -18 +16,2 @@ int main(){
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index f93d012..1cf7f24 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -6,3 +6,3 @@ class Dummy {
-    char* useless;
-    int numb;
-    Dummy() :numb(0), useless("\0"){}
+    char* useless { "\0" };
+    int numb { 0 };
+    Dummy() { }
@@ -10,2 +10,2 @@ class Dummy {
-    public:
-    void *not_useful(char *str){useless = str;}
+public:
+    auto not_useful(char* str) -> void* { useless = str; }

Used clang-format v17.0.4

Only 5 out of 7 new clang-format concerns fit within this pull request's diff.

Click here for the full clang-format patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 1bf553e..86d9f03 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -4,0 +5,2 @@
+int main()
+{
@@ -6,6 +8,2 @@
-
-
-int main(){
-
-    for (;;) break;
-
+    for (;;)
+        break;
@@ -15,4 +13,2 @@ int main(){
-
-
-
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index f93d012..dad4fd6 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -3,2 +2,0 @@
-
-
@@ -8,4 +6,8 @@ class Dummy {
-    Dummy() :numb(0), useless("\0"){}
-
-    public:
-    void *not_useful(char *str){useless = str;}
+    Dummy()
+        : numb(0)
+        , useless("\0")
+    {
+    }
+
+public:
+    void* not_useful(char* str) { useless = str; }
@@ -14,19 +16 @@ class Dummy {
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-struct LongDiff
-{
+struct LongDiff {
@@ -35 +18,0 @@ struct LongDiff
-

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-12-23T05:40:09Z

src/demo.cpp


-// using size_t from cstddef
-size_t dummyFunc(size_t i) { return i; }



clang-format suggestion

Suggested change

int main()

{

github-actions · 2024-12-23T05:40:09Z

src/demo.cpp

+
+
+int main(){
+
+    for (;;) break;
+


clang-format suggestion

Suggested change

int main(){

for (;;) break;

for (;;)

break;

clang-tidy diagnostics

use a trailing return type for this function [modernize-use-trailing-return-type]

statement should be inside braces [readability-braces-around-statements]

Suggested change

int main(){

for (;;) break;

for (;;) {

break;

}

github-actions · 2024-12-23T05:40:09Z

src/demo.cpp

+
+
+
+    return 0;}


clang-format suggestion

Suggested change

return 0;}

return 0;

}

github-actions · 2024-12-23T05:40:10Z

src/demo.hpp

+    Dummy() :numb(0), useless("\0"){}

    public:
-    void *not_usefull(char *str){
-        useless = str;
-        return 0;
-    }
+    void *not_useful(char *str){useless = str;}


clang-format suggestion

Suggested change

Dummy() :numb(0), useless("\0"){}

public:

void *not_usefull(char *str){

useless = str;

return 0;

}

void *not_useful(char *str){useless = str;}

Dummy()

: numb(0)

, useless("\0")

{

}

public:

void* not_useful(char* str) { useless = str; }

github-actions · 2024-12-23T05:40:10Z

src/demo.hpp



 struct LongDiff
 {
+
    long diff;



clang-format suggestion

Please remove the line(s)

35

github-actions · 2024-12-23T05:40:10Z

src/demo.cpp

@@ -1,17 +1,18 @@
 /** This is a very ugly test code (doomed to fail linting) */
 #include "demo.hpp"
-#include <cstdio>
-#include <cstddef>
+#include <stdio.h>



clang-tidy suggestion

Suggested change

auto main() -> int

{

github-actions · 2024-12-23T05:40:10Z

src/demo.cpp

+
+
+
+    return 0;}


clang-tidy suggestion

Suggested change

return 0;}

return 0;

}

github-actions · 2024-12-23T05:40:10Z

src/demo.cpp

+int main(){
+
+    for (;;) break;
+

    printf("Hello world!\n");


clang-tidy diagnostic

src/demo.cpp:13:5: warning: [cppcoreguidelines-pro-type-vararg]

do not call c-style vararg functions

13 | printf("Hello world!\n"); | ^

github-actions · 2024-12-23T05:40:10Z

src/demo.hpp

    char* useless;
    int numb;
+    Dummy() :numb(0), useless("\0"){}


clang-tidy suggestion

Suggested change

char* useless;

int numb;

Dummy() :numb(0), useless("\0"){}

char* useless { "\0" };

int numb { 0 };

Dummy() { }

github-actions · 2024-12-23T05:40:10Z

src/demo.hpp

    public:
-    void *not_usefull(char *str){
-        useless = str;
-        return 0;
-    }
+    void *not_useful(char *str){useless = str;}


clang-tidy diagnostics

use a trailing return type for this function [modernize-use-trailing-return-type]

Suggested change

public:

void *not_usefull(char *str){

useless = str;

return 0;

}

void *not_useful(char *str){useless = str;}

public:

auto not_useful(char* str) -> void* { useless = str; }

github-actions

Cpp-Linter Review

Used clang-tidy v17.0.4

Click here for the full clang-tidy patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 1bf553e..8caf462 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -2,2 +2 @@
-#include "demo.hpp"
-#include <stdio.h>
+#include <cstdio>
@@ -4,0 +4,2 @@
+auto main() -> int
+{
@@ -6,6 +7,3 @@
-
-
-int main(){
-
-    for (;;) break;
-
+    for (;;) {
+        break;
+    }
@@ -18 +16,2 @@ int main(){
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index f93d012..1cf7f24 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -6,3 +6,3 @@ class Dummy {
-    char* useless;
-    int numb;
-    Dummy() :numb(0), useless("\0"){}
+    char* useless { "\0" };
+    int numb { 0 };
+    Dummy() { }
@@ -10,2 +10,2 @@ class Dummy {
-    public:
-    void *not_useful(char *str){useless = str;}
+public:
+    auto not_useful(char* str) -> void* { useless = str; }

Used clang-format v17.0.4

Only 5 out of 7 new clang-format concerns fit within this pull request's diff.

Click here for the full clang-format patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 1bf553e..86d9f03 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -4,0 +5,2 @@
+int main()
+{
@@ -6,6 +8,2 @@
-
-
-int main(){
-
-    for (;;) break;
-
+    for (;;)
+        break;
@@ -15,4 +13,2 @@ int main(){
-
-
-
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index f93d012..dad4fd6 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -3,2 +2,0 @@
-
-
@@ -8,4 +6,8 @@ class Dummy {
-    Dummy() :numb(0), useless("\0"){}
-
-    public:
-    void *not_useful(char *str){useless = str;}
+    Dummy()
+        : numb(0)
+        , useless("\0")
+    {
+    }
+
+public:
+    void* not_useful(char* str) { useless = str; }
@@ -14,19 +16 @@ class Dummy {
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-struct LongDiff
-{
+struct LongDiff {
@@ -35 +18,0 @@ struct LongDiff
-

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-12-23T06:32:22Z

src/demo.cpp


-// using size_t from cstddef
-size_t dummyFunc(size_t i) { return i; }



clang-format suggestion

Suggested change

int main()

{

github-actions · 2024-12-23T06:32:23Z

src/demo.cpp

+
+
+int main(){
+
+    for (;;) break;
+


clang-format suggestion

Suggested change

int main(){

for (;;) break;

for (;;)

break;

clang-tidy diagnostics

use a trailing return type for this function [modernize-use-trailing-return-type]

statement should be inside braces [readability-braces-around-statements]

Suggested change

int main(){

for (;;) break;

for (;;) {

break;

}

github-actions · 2024-12-23T06:32:23Z

src/demo.cpp

+
+
+
+    return 0;}


clang-format suggestion

Suggested change

return 0;}

return 0;

}

github-actions · 2024-12-23T06:32:23Z

src/demo.hpp

+    Dummy() :numb(0), useless("\0"){}

    public:
-    void *not_usefull(char *str){
-        useless = str;
-        return 0;
-    }
+    void *not_useful(char *str){useless = str;}


clang-format suggestion

Suggested change

Dummy() :numb(0), useless("\0"){}

public:

void *not_usefull(char *str){

useless = str;

return 0;

}

void *not_useful(char *str){useless = str;}

Dummy()

: numb(0)

, useless("\0")

{

}

public:

void* not_useful(char* str) { useless = str; }

github-actions · 2024-12-23T06:32:23Z

src/demo.hpp



 struct LongDiff
 {
+
    long diff;



clang-format suggestion

Please remove the line(s)

35

github-actions · 2024-12-23T06:32:23Z

src/demo.cpp

@@ -1,17 +1,18 @@
 /** This is a very ugly test code (doomed to fail linting) */
 #include "demo.hpp"
-#include <cstdio>
-#include <cstddef>
+#include <stdio.h>



clang-tidy suggestion

Suggested change

auto main() -> int

{

github-actions · 2024-12-23T06:32:23Z

src/demo.cpp

+
+
+
+    return 0;}


clang-tidy suggestion

Suggested change

return 0;}

return 0;

}

github-actions · 2024-12-23T06:32:23Z

src/demo.cpp

+int main(){
+
+    for (;;) break;
+

    printf("Hello world!\n");


clang-tidy diagnostic

src/demo.cpp:13:5: warning: [cppcoreguidelines-pro-type-vararg]

do not call c-style vararg functions

13 | printf("Hello world!\n"); | ^

github-actions · 2024-12-23T06:32:23Z

src/demo.hpp

    char* useless;
    int numb;
+    Dummy() :numb(0), useless("\0"){}


clang-tidy suggestion

Suggested change

char* useless;

int numb;

Dummy() :numb(0), useless("\0"){}

char* useless { "\0" };

int numb { 0 };

Dummy() { }

github-actions · 2024-12-23T06:32:26Z

src/demo.hpp

    public:
-    void *not_usefull(char *str){
-        useless = str;
-        return 0;
-    }
+    void *not_useful(char *str){useless = str;}


clang-tidy diagnostics

use a trailing return type for this function [modernize-use-trailing-return-type]

Suggested change

public:

void *not_usefull(char *str){

useless = str;

return 0;

}

void *not_useful(char *str){useless = str;}

public:

auto not_useful(char* str) -> void* { useless = str; }

2bndy5 added 4 commits December 12, 2024 08:00

switch to dev branch

07ba84f

update lang configs

d6831a0

make source changes

01e2ebf

switch branches

88d5db6

This comment was marked as outdated.

Sign in to view

2bndy5 force-pushed the test-new-pr-review branch from e051bb5 to b75c847 Compare December 23, 2024 05:16

This comment was marked as outdated.

Sign in to view

2bndy5 force-pushed the test-new-pr-review branch 2 times, most recently from 9c83a2b to 88d5db6 Compare December 23, 2024 05:39

github-actions bot requested changes Dec 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test new pr review #46

Test new pr review #46

2bndy5 commented Dec 20, 2024

github-actions bot commented Dec 20, 2024 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot left a comment •

edited by 2bndy5

Loading

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot left a comment

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024

github-actions bot Dec 23, 2024


		// using size_t from cstddef
		size_t dummyFunc(size_t i) { return i; }

Test new pr review #46

Are you sure you want to change the base?

Test new pr review #46

Conversation

2bndy5 commented Dec 20, 2024

github-actions bot commented Dec 20, 2024 • edited Loading

Cpp-Linter Report ⚠️

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot left a comment • edited by 2bndy5 Loading

Choose a reason for hiding this comment

Cpp-Linter Review

Used clang-tidy v17.0.4

Used clang-format v17.0.4

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-format suggestion

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-format suggestion

clang-tidy diagnostics

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-format suggestion

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-format suggestion

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-format suggestion

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-tidy suggestion

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-tidy suggestion

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-tidy suggestion

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-tidy diagnostics

github-actions bot left a comment

Choose a reason for hiding this comment

Cpp-Linter Review

Used clang-tidy v17.0.4

Used clang-format v17.0.4

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-format suggestion

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-format suggestion

clang-tidy diagnostics

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-format suggestion

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-format suggestion

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-format suggestion

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-tidy suggestion

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-tidy suggestion

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-tidy diagnostic

github-actions bot Dec 23, 2024

Choose a reason for hiding this comment

clang-tidy suggestion

github-actions bot Dec 23, 2024

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot left a comment •

edited by 2bndy5

Loading