Test new pr review #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cpp-Linter Report
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v17.0.4
Only 6 out of 7 clang-tidy concerns fit within this pull request's diff.
Click here for the full clang-tidy patch
diff --git a/src/demo.cpp b/src/demo.cpp
index 1bf553e..8caf462 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -2,2 +2 @@
-#include "demo.hpp"
-#include <stdio.h>
+#include <cstdio>
@@ -4,0 +4,2 @@
+auto main() -> int
+{
@@ -6,6 +7,3 @@
-
-
-int main(){
-
- for (;;) break;
-
+ for (;;) {
+ break;
+ }
@@ -18 +16,2 @@ int main(){
- return 0;}
+ return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index f93d012..1cf7f24 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -6,3 +6,3 @@ class Dummy {
- char* useless;
- int numb;
- Dummy() :numb(0), useless("\0"){}
+ char* useless { "\0" };
+ int numb { 0 };
+ Dummy() { }
@@ -10,2 +10,2 @@ class Dummy {
- public:
- void *not_useful(char *str){useless = str;}
+public:
+ auto not_useful(char* str) -> void* { useless = str; }
Used clang-format v17.0.4
Only 5 out of 7 clang-format concerns fit within this pull request's diff.
Click here for the full clang-format patch
diff --git a/src/demo.cpp b/src/demo.cpp
index 1bf553e..86d9f03 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -4,0 +5,2 @@
+int main()
+{
@@ -6,6 +8,2 @@
-
-
-int main(){
-
- for (;;) break;
-
+ for (;;)
+ break;
@@ -15,4 +13,2 @@ int main(){
-
-
-
- return 0;}
+ return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index f93d012..dad4fd6 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -3,2 +2,0 @@
-
-
@@ -8,4 +6,8 @@ class Dummy {
- Dummy() :numb(0), useless("\0"){}
-
- public:
- void *not_useful(char *str){useless = str;}
+ Dummy()
+ : numb(0)
+ , useless("\0")
+ {
+ }
+
+public:
+ void* not_useful(char* str) { useless = str; }
@@ -14,19 +16 @@ class Dummy {
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-struct LongDiff
-{
+struct LongDiff {
@@ -35 +18,0 @@ struct LongDiff
-
Have any feedback or feature suggestions? Share it here.
|
|
||
| // using size_t from cstddef | ||
| size_t dummyFunc(size_t i) { return i; } | ||
|
|
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| int main() | |
| { |
Comment on lines
+6
to
+11
|
|
||
|
|
||
| int main(){ | ||
|
|
||
| for (;;) break; | ||
|
|
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| int main(){ | |
| for (;;) break; | |
| for (;;) | |
| break; |
clang-tidy diagnostics
- use a trailing return type for this function [modernize-use-trailing-return-type]
- statement should be inside braces [readability-braces-around-statements]
Suggested change
| int main(){ | |
| for (;;) break; | |
| for (;;) { | |
| break; | |
| } |
Comment on lines
+15
to
+18
|
|
||
|
|
||
|
|
||
| return 0;} |
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| return 0;} | |
| return 0; | |
| } |
Comment on lines
+8
to
+11
| Dummy() :numb(0), useless("\0"){} | ||
|
|
||
| public: | ||
| void *not_usefull(char *str){ | ||
| useless = str; | ||
| return 0; | ||
| } | ||
| void *not_useful(char *str){useless = str;} |
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| Dummy() :numb(0), useless("\0"){} | |
| public: | |
| void *not_usefull(char *str){ | |
| useless = str; | |
| return 0; | |
| } | |
| void *not_useful(char *str){useless = str;} | |
| Dummy() | |
| : numb(0) | |
| , useless("\0") | |
| { | |
| } | |
| public: | |
| void* not_useful(char* str) { useless = str; } |
|
|
||
|
|
||
| struct LongDiff | ||
| { | ||
|
|
||
| long diff; | ||
|
|
There was a problem hiding this comment.
clang-format suggestion
Please remove the line(s)
- 35
Comment on lines
2
to
+3
| #include "demo.hpp" | ||
| #include <cstdio> | ||
| #include <cstddef> | ||
| #include <stdio.h> |
There was a problem hiding this comment.
clang-tidy diagnostics
- included header demo.hpp is not used directly [misc-include-cleaner]
- inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers]
Suggested change
| #include "demo.hpp" | |
| #include <cstdio> | |
| #include <cstddef> | |
| #include <stdio.h> | |
| #include <cstdio> |
| @@ -1,17 +1,18 @@ | |||
| /** This is a very ugly test code (doomed to fail linting) */ | |||
| #include "demo.hpp" | |||
| #include <cstdio> | |||
| #include <cstddef> | |||
| #include <stdio.h> | |||
|
|
|||
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| auto main() -> int | |
| { |
Comment on lines
6
to
+8
| char* useless; | ||
| int numb; | ||
| Dummy() :numb(0), useless("\0"){} |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| char* useless; | |
| int numb; | |
| Dummy() :numb(0), useless("\0"){} | |
| char* useless { "\0" }; | |
| int numb { 0 }; | |
| Dummy() { } |
Comment on lines
10
to
+11
| public: | ||
| void *not_usefull(char *str){ | ||
| useless = str; | ||
| return 0; | ||
| } | ||
| void *not_useful(char *str){useless = str;} |
There was a problem hiding this comment.
clang-tidy diagnostics
- use a trailing return type for this function [modernize-use-trailing-return-type]
Suggested change
| public: | |
| void *not_usefull(char *str){ | |
| useless = str; | |
| return 0; | |
| } | |
| void *not_useful(char *str){useless = str;} | |
| public: | |
| auto not_useful(char* str) -> void* { useless = str; } |
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v17.0.4
Only 2 out of 7 clang-tidy concerns fit within this pull request's diff.
Click here for the full clang-tidy patch
diff --git a/src/demo.hpp b/src/demo.hpp
index f93d012..1cf7f24 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -6,3 +6,3 @@ class Dummy {
- char* useless;
- int numb;
- Dummy() :numb(0), useless("\0"){}
+ char* useless { "\0" };
+ int numb { 0 };
+ Dummy() { }
@@ -10,2 +10,2 @@ class Dummy {
- public:
- void *not_useful(char *str){useless = str;}
+public:
+ auto not_useful(char* str) -> void* { useless = str; }
diff --git a/src/demo.cpp b/src/demo.cpp
index 1bf553e..8caf462 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -2,2 +2 @@
-#include "demo.hpp"
-#include <stdio.h>
+#include <cstdio>
@@ -4,0 +4,2 @@
+auto main() -> int
+{
@@ -6,6 +7,3 @@
-
-
-int main(){
-
- for (;;) break;
-
+ for (;;) {
+ break;
+ }
@@ -18 +16,2 @@ int main(){
- return 0;}
+ return 0;
+}
Used clang-format v17.0.4
Only 0 out of 7 clang-format concerns fit within this pull request's diff.
Click here for the full clang-format patch
diff --git a/src/demo.hpp b/src/demo.hpp
index f93d012..dad4fd6 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -3,2 +2,0 @@
-
-
@@ -8,4 +6,8 @@ class Dummy {
- Dummy() :numb(0), useless("\0"){}
-
- public:
- void *not_useful(char *str){useless = str;}
+ Dummy()
+ : numb(0)
+ , useless("\0")
+ {
+ }
+
+public:
+ void* not_useful(char* str) { useless = str; }
@@ -14,19 +16 @@ class Dummy {
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-struct LongDiff
-{
+struct LongDiff {
@@ -35 +18,0 @@ struct LongDiff
-
diff --git a/src/demo.cpp b/src/demo.cpp
index 1bf553e..86d9f03 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -4,0 +5,2 @@
+int main()
+{
@@ -6,6 +8,2 @@
-
-
-int main(){
-
- for (;;) break;
-
+ for (;;)
+ break;
@@ -15,4 +13,2 @@ int main(){
-
-
-
- return 0;}
+ return 0;
+}
Have any feedback or feature suggestions? Share it here.
|
|
||
|
|
||
|
|
||
| return 0;} |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| return 0;} | |
| return 0; | |
| } |
| int main(){ | ||
|
|
||
| for (;;) break; | ||
|
|
||
|
|
||
| printf("Hello world!\n"); |
There was a problem hiding this comment.
clang-tidy diagnostic
src/demo.cpp:13:5: warning: [cppcoreguidelines-pro-type-vararg]
do not call c-style vararg functions
13 | printf("Hello world!\n");
| ^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fresh attempt