-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare to test branch #32
Conversation
test action CI
Cpp-Linter Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cpp-linter Review
Click here for the full clang-tidy patch
diff --git a/src/demo.cpp b/src/demo.cpp
index fc295c3..b160609 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -3 +3 @@
-#include <stdio.h>
+#include <cstdio>
@@ -4,0 +5,2 @@
+auto main() -> int
+{
@@ -6,6 +8,3 @@
-
-
-int main(){
-
- for (;;) break;
-
+ for (;;) {
+ break;
+ }
@@ -18 +17,2 @@ int main(){
- return 0;}
+ return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index a429f5c..115b0de 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -6,3 +6,3 @@ class Dummy {
- char* useless;
- int numb;
- Dummy() :numb(0), useless("\0"){}
+ char* useless { "\0" };
+ int numb { 0 };
+ Dummy() { }
@@ -10,2 +10,2 @@ class Dummy {
- public:
- void *not_useful(char *str){useless = str;}
+public:
+ auto not_useful(char* str) -> void* { useless = str; }
Have any feedback or feature suggestions? Share it here.
@@ -1,17 +1,18 @@ | |||
/** This is a very ugly test code (doomed to fail linting) */ | |||
#include "demo.hpp" | |||
#include <cstdio> | |||
#include <cstddef> | |||
#include <stdio.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy diagnostics
- inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers]
#include <stdio.h> | |
#include <cstdio> |
|
||
// using size_t from cstddef | ||
size_t dummyFunc(size_t i) { return i; } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy suggestions
auto main() -> int | |
{ |
|
||
|
||
int main(){ | ||
|
||
for (;;) break; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy diagnostics
- use a trailing return type for this function [modernize-use-trailing-return-type]
- statement should be inside braces [readability-braces-around-statements]
int main(){ | |
for (;;) break; | |
for (;;) { | |
break; | |
} |
|
||
|
||
|
||
return 0;} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy suggestions
return 0;} | |
return 0; | |
} |
char* useless; | ||
int numb; | ||
Dummy() :numb(0), useless("\0"){} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy diagnostics
- use default member initializer for 'useless' [modernize-use-default-member-init]
- use default member initializer for 'numb' [modernize-use-default-member-init]
char* useless; | |
int numb; | |
Dummy() :numb(0), useless("\0"){} | |
char* useless { "\0" }; | |
int numb { 0 }; | |
Dummy() { } |
public: | ||
void *not_usefull(char *str){ | ||
useless = str; | ||
return 0; | ||
} | ||
void *not_useful(char *str){useless = str;} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy diagnostics
- use a trailing return type for this function [modernize-use-trailing-return-type]
public: | |
void *not_usefull(char *str){ | |
useless = str; | |
return 0; | |
} | |
void *not_useful(char *str){useless = str;} | |
public: | |
auto not_useful(char* str) -> void* { useless = str; } |
int main(){ | ||
|
||
for (;;) break; | ||
|
||
|
||
printf("Hello world!\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy diagnostic
src/demo.cpp:13:5: warning: [cppcoreguidelines-pro-type-vararg]
do not call c-style vararg functions
printf("Hello world!\n");
^
test action CI