-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install clang-tools into current pre-commit venv #29
Conversation
Thanks so much for your fixing and refactoring. Can you please review sonarcloud issues, my comments and also get CI to pass? |
The tests are failing on github actions now, because clang tools are already installed there, so the tests that assumed that when starting the tests, we don't have the tools fail. Will think about how to actually test that the installation works. |
Hi @maxnoe thanks again for your excellent changes. it's ok if you don't have a good solution for the test failure, you can skip it for now, although it might reduce code coverage, but we can record skip tests by creating another ticket. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
- Coverage 77.84% 72.53% -5.31%
==========================================
Files 7 6 -1
Lines 176 142 -34
==========================================
- Hits 137 103 -34
Misses 39 39 ☔ View full report in Codecov by Sentry. |
18f609e
to
d7dca0d
Compare
Quality Gate passedIssues Measures |
I tried fixing #28, but this turned into a somewhat larger refactor, as I found a couple of more issues.
First:
try-repo
doesn't actually support running the current code and it doesn't read the config file and it doesn't support passing args. There are a couple of issues about that in the pre-commit repo, but I didn't find a really good solution.Second: I could simplify the code a lot by using an
ArgumentParser
for the command line args and by using python functions fromclang_tools
instead of using subprocess to call the cli.Let me know what you think.