-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix static binaries failed on macOS from version 15~18 #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow 🤩 it works @2bndy5 👍
Well, I can see that it builds successfully. But does the CI also dry-run the executables (with say |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be honest: Sometimes I surprise myself. I didn't think this would be the only solution needed. I was half expecting another problem to surface after we squashed the libzstd problem... 🤞🏼
I see that the test CI only works with latest release. Looks like we'll have to merge and publish a release with these changes. Then we can run the test CI. If that all works out then clang-tools-pip should be updated to use the new release.
It's a good idea to test executables in the build CI to check it before merging or publishing. I'll add the test to build CI in the next pull request. |
closes #26