Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Open country selection for FR papers #681

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: Open country selection for FR papers #681

merged 1 commit into from
Oct 23, 2024

Conversation

Merkur39
Copy link
Member

Two documents have a slightly different route between their FR and foreign versions: the driving license and the national identity card.

The creation of one of these FR papers does not offer a country selection step, which poses a problem if you wish to edit the country after the paper has been created.

The best approach is to load the paperDefinition of the foreign version to open the country selection step.

Copy link

bundlemon bot commented Oct 22, 2024

BundleMon

Files updated (1)
Status Path Size Limits
app/mespapiers.(hash).js
1.64MB (-32B 0%) -
Unchanged files (40)
Status Path Size Limits
vendors/mespapiers.(hash).js
1.95MB -
services/expiration/mespapiers.js
1.76MB -
services/metadataMigration/mespapiers.js
398.98KB -
services/launchTriggers/mespapiers.js
396.56KB -
intents/mespapiers.(hash).js
84.62KB -
img/IlluPassportDate.(hash).png
38.4KB -
img/IlluPassportNumber.(hash).png
37.98KB -
img/IlluPassport.(hash).png
37.87KB -
vendors-mespapiers.(hash).(hash).min.css
37.44KB -
img/IlluNationalHealthInsuranceCardNumber.(ha
sh).png
24.89KB -
img/IlluNationalHealthInsuranceCardDateHelp.(
hash).png
24.64KB -
img/IlluCafNumberHelp.(hash).png
21.67KB -
img/IlluIdCardNumberHelp.(hash).png
13KB -
img/IlluDriverLicenseBack.(hash).png
12.72KB -
img/IlluIdCardFront.(hash).png
12.58KB -
img/IlluIdCardBack.(hash).png
12.43KB -
img/IlluResidencePermitExpirationDateHelp.(ha
sh).png
12.17KB -
img/IlluResidencePermitNumberHelp.(hash).png
12.16KB -
img/IlluIdCardExpirationDateHelp.(hash).png
12.09KB -
img/IlluResidencePermitFront.(hash).png
12.08KB -
img/IlluDriverLicenseNumberHelp.(hash).png
11.93KB -
img/IlluDriverLicenseFront.(hash).png
11.85KB -
img/IlluDriverLicenseObtentionDateHelp.(hash)
.png
11.74KB -
img/IlluResidencePermitBack.(hash).png
11.01KB -
img/QRCode.(hash).png
9.77KB -
img/IlluNationalHealthInsuranceCardFront.(has
h).png
9.39KB -
img/IlluVehicleRegistration.(hash).png
8.92KB -
img/IlluNewNationalIdCardFront.(hash).png
8.65KB -
img/IlluOldNationalIdCardFront.(hash).png
7.86KB -
img/IlluDiploma.(hash).png
5.59KB -
img/IlluIBAN.(hash).png
3.81KB -
img/IlluCovidVaccineCertificate.(hash).png
2.96KB -
img/IlluInvoice.(hash).png
2.33KB -
img/IlluWorkContract.(hash).png
2.24KB -
img/marker-icon.(hash).png
1.45KB -
img/layers-2x.(hash).png
1.25KB -
img/layers.(hash).png
719B -
app-mespapiers.(hash).min.css
568B -
img/appstore.(hash).png
362B -
img/playstore.(hash).png
328B -

Total files change -32B 0%

Groups updated (1)
Status Path Size Limits
**/*.js
6.69MB (-32B 0%) -
Unchanged groups (2)
Status Path Size Limits
img/.
401.43KB -
**/*.css
38.35KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Two documents have a slightly different route between
their FR and foreign versions: the driving license and
the national identity card.

The creation of one of these FR papers does not offer
a country selection step, which poses a problem if you
wish to edit the country after the paper has been created.

The best approach is to load the paperDefinition of
the foreign version to open the country selection step.
@Merkur39 Merkur39 merged commit 993e934 into master Oct 23, 2024
2 checks passed
@Merkur39 Merkur39 deleted the feat/ver-1008 branch October 23, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants