fix: Save a new paper from the Cozy filePicker #674
Merged
+15
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also retrieve the original file name, to display something consistent.
Merkur39
force-pushed
the
feat/ver-983
branch
from
4efdc8f to
a8ccf42
Compare
JF-Cozy
approved these changes
Oct 15, 2024
| const { data: fileSelected } = await client.query( | ||
| buildedFileQueryById.definition, | ||
| buildedFileQueryById.options | ||
| ) |
There was a problem hiding this comment.
on ne gère pas le loading ici et si je comprends bien le fetch se fait après un click sur un bouton (quand on souhaite sélectionner un fichier), ce n'est pas gênant avec une connexion lente ?
There was a problem hiding this comment.
Ici le fichier sera déjà dans le store puisque sélectionné au préalable. Donc pas de soucis lié au réseaux 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also retrieve the original file name, to display something consistent.