Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure use correct format locales #2731

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: Ensure use correct format locales #2731

merged 1 commit into from
Dec 20, 2024

Conversation

Merkur39
Copy link
Member

@Merkur39 Merkur39 commented Dec 20, 2024

Following version 115.0.0, the format of 3 locales has changed:

  • en -> en-US
  • zh_cn -> zh-CN
  • zh_tw -> zh-TW

More details here: https://github.com/date-fns/date-fns/blob/main/CHANGELOG.md#200---2019-08-20

The constant DEFAULT_LANG=“en” is not changed because it is used by Polyglot, which must not change. This is directly related to the folder names in our apps..

Following version 115.0.0, the format of 3 locales has changed:
- `en -> en-US`
- `zh_cn -> zh-CN`
- `zh_tw -> zh-TW`

More details here:
https://github.com/date-fns/date-fns/blob/main/CHANGELOG.md#200---2019-08-20

The constant `DEFAULT_LANG=“en”` is not changed
because it is used by Polyglot, which must not change.
This is directly related to the folder names in our apps..
Copy link

bundlemon bot commented Dec 20, 2024

BundleMon

Unchanged files (3)
Status Path Size Limits
dist/cozy-ui.min.css
20.23KB +10%
transpiled/react/stylesheet.css
16.93KB -
dist/cozy-ui.utils.min.css
10.91KB +10%

No change in files bundle size

Groups updated (1)
Status Path Size Limits
transpiled/react/**
666.23KB (+196B +0.03%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@Merkur39 Merkur39 merged commit 5d078db into master Dec 20, 2024
12 checks passed
@Merkur39 Merkur39 deleted the fix/i18n-locale branch December 20, 2024 11:02
@cozy-bot
Copy link

🎉 This PR is included in version 115.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants