Skip to content

Commit

Permalink
fix(AppTile): Display the name of the developer instead custom property
Browse files Browse the repository at this point in the history
The properties are adapted only once in the app that consumes the component, to be less specific.
  • Loading branch information
cballevre committed Sep 23, 2024
1 parent 6717f4f commit fcd06ca
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions react/AppTile/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ export const AppTile = ({

const isInMaintenanceWithSpecificDisplay =
displaySpecificMaintenanceStyle && statusLabel === APP_STATUS.maintenance
const tileSubtitle = isShortcutFile(app)
? app.metadata?.source
: developer.name

return (
<Tile
Expand Down Expand Up @@ -107,8 +104,8 @@ export const AppTile = ({
<TileTitle isMultiline={!statusLabel}>
{namePrefix ? `${namePrefix} ${name}` : name}
</TileTitle>
{showDeveloper && (
<TileSubtitle>{`${t('app_item.by')} ${tileSubtitle}`}</TileSubtitle>
{developer.name && showDeveloper && (
<TileSubtitle>{`${t('app_item.by')} ${developer.name}`}</TileSubtitle>
)}
{statusToDisplay && (
<TileFooter isAccent={statusLabel === APP_STATUS.update}>
Expand Down

0 comments on commit fcd06ca

Please sign in to comment.