Add a route for uploading avatars #4499
Open
+217
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
reviewed
Dec 18, 2024
| return &avatar{fs} | ||
| } | ||
|
|
||
| type avatar struct { |
There was a problem hiding this comment.
avatarFs seems more appropriate since this struct does not old data about avatars themselves but rather implements the interface allowing to manage them.
| _ = u.fs.Remove(u.tmpname) | ||
| return err | ||
| } | ||
| return u.fs.Rename(u.tmpname, "avatar") |
There was a problem hiding this comment.
nit: a constant storing the avatar filename would be nice
| header := c.Request().Header | ||
| size := c.Request().ContentLength | ||
| if size > 20_000_000 { | ||
| return jsonapi.BadRequest(errors.New("Avatar is too big")) |
There was a problem hiding this comment.
I think we should return a 413 Entity Too Large error here.
| } | ||
| header := c.Request().Header | ||
| size := c.Request().ContentLength | ||
| if size > 20_000_000 { |
There was a problem hiding this comment.
We could have a MaxFileSize() method in the AvatarFS struct like the one in the Fs interface.
There was a problem hiding this comment.
Maybe this should be an error returned by CreateAvatar()?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.