[VO-1227] chore: Migrate to Rsbuild #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cballevre
force-pushed
the
feat/migrate-to-rsbuild
branch
from
552a4a3 to
a2d7795
Compare
cballevre
changed the title
cballevre
force-pushed
the
feat/migrate-to-rsbuild
branch
from
a2d7795 to
98ac75f
Compare
BundleMonFiles added (17)
Files removed (9)
Files updated (2)
Total files change -470.53KB -14.2% Groups added (3)
Final result: ✅ View report in BundleMon website ➡️ |
zatteo
approved these changes
Dec 3, 2024
|
@cballevre very nice work |
Ldoppea
reviewed
Dec 10, 2024
|
|
||
| let middlewares = [thunkMiddleware, loggerMiddleware] | ||
|
|
||
| // Enable Redux dev tools | ||
| const composeEnhancers = | ||
| (__DEVELOPMENT__ && window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__) || compose | ||
| (flag('debug') && window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__) || compose |
There was a problem hiding this comment.
As the flag plugin is initialized on client's login event and because client.login() is asynchronous, it seems like relying on flag('debug') here would be subject to race condition, wouldn't it?
I suppose it would work here because on web apps, the client.login() only access local resources, so it would be fast enough to ends before the composeEnhancers initialisation. But it seems a bit risky.
|
This commit message says the opposite of what is done. Is the error on the message? or on what have been done? |
|
This a mistake on the message 🙁 |
Ldoppea
force-pushed
the
feat/migrate-to-rsbuild
branch
from
98ac75f to
ca82d75
Compare
In cozy-script we used to enforce the development mode when doing a
`yarn watch`
The development mode changes the build behavior by removing some steps
like minification which results to a faster build
A side effect is that the code generated from the `watch` command is a
bit different than the one generated from `build` command. This may
produce some differences on the app's behavior, but this is rare enough
(happened 1 or 2 times in the past years) so we consider the speed gain
to still be valuable. Also we know that we should run a `build` locally
as ultimate check before pushing new code to the git repo
So we want to enable this mode in the new Rsbuild configuration
Here are the timings for initial build and then 4 differents edits in
the code that trigger a re-build
yarn watch
```
7,57s (initial build)
5,79s
5,83s
6,68s
7,15s
```
yarn watch --mode development
```
7,00s (initial build)
0,69s
0,45s
0,92s
0,46s
```
Related code:
https://github.com/cozy/create-cozy-app/blob/master/packages/cozy-scripts/scripts/watch.js#L13
Ldoppea
force-pushed
the
feat/migrate-to-rsbuild
branch
from
ca82d75 to
588ab49
Compare
Ldoppea
force-pushed
the
feat/migrate-to-rsbuild
branch
from
44e02d4 to
8f998c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs: