Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create album button blank page #54

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

zatteo
Copy link
Contributor

@zatteo zatteo commented Nov 27, 2024

In 5587dca, we added params to ALBUMS_MUTATIONS with an extra function in CreateAlbumPicker leading to the following error "Functions are not valid as a React child. This may happen if you return a Component instead of from render. Or maybe you meant to call this function rather than return it."

### ✨ Features

*

### 🐛 Bug Fixes

* "Create album" button on "Albums" page displayed a blank screen 

### 🔧 Tech

*

In 5587dca, we added params to
ALBUMS_MUTATIONS with an extra function in CreateAlbumPicker leading
to the following error "Functions are not valid as a React child.
This may happen if you return a Component instead of <Component />
from render. Or maybe you meant to call this function rather than
return it."
@zatteo zatteo requested a review from cballevre as a code owner November 27, 2024 14:18
Copy link

bundlemon bot commented Nov 27, 2024

BundleMon

Unchanged files (11)
Status Path Size Limits
vendors/photos.(hash).js
1.22MB -
public/photos.(hash).js
1.2MB -
services/onPhotoUpload/photos.js
266.49KB -
services/onPhotoTrashed/photos.js
256.88KB -
public/cozy-client-js.js
159.28KB -
app/photos.(hash).js
57.12KB -
public/photos.(hash).min.css
46.47KB -
app-photos.(hash).min.css
19.75KB -
manifest.webapp
1.12KB -
index.html
518B -
manifest.json
185B -

Total files change +8B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

@cballevre cballevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zatteo zatteo merged commit 01c06c6 into master Nov 27, 2024
4 checks passed
@zatteo zatteo deleted the fix/photo-picker-creation branch November 27, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants