Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps and always display folder link to avoid blink #55

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Update deps and always display folder link to avoid blink #55

merged 2 commits into from
Nov 6, 2024

Conversation

zatteo
Copy link
Contributor

@zatteo zatteo commented Nov 6, 2024 

### ✨ Features

*

### 🐛 Bug Fixes

*

### 🔧 Tech

*

zatteo added 2 commits November 6, 2024 14:18
@zatteo
feat: Update deps
848d9a6 
Especially trying to fix index on queries with cozy-client update.

settings permission has been added to handle dark mode.
@zatteo
fix: Always display folder link to avoid blink
f483da6
@zatteo zatteo requested a review from ecnivtwelve as a code owner November 6, 2024 13:21
@zatteo zatteo requested a review from cballevre November 6, 2024 13:21
@zatteo zatteo requested a review from paultranvan November 6, 2024 13:22
@zatteo zatteo requested a review from Merkur39 November 6, 2024 13:22
@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 6, 2024

BundleMon

Files updated (3)
Status Path Size Limits
✅ vendors/papillon.(hash).js
 605.7KB (+6.16KB +1.03%) -
✅ app/papillon.(hash).js
 16.01KB (+13B +0.08%) -
✅ vendors-papillon.(hash).(hash).min.css
 29.7KB (-1.14KB -3.7%) -
Unchanged files (3)
Status Path Size Limits
✅ img/import-school.(hash).svg
 18.15KB -
✅ img/pronote.(hash).svg
 1.83KB -
✅ app-papillon.(hash).min.css
 20B -

Total files change +5.03KB +0.76%

Groups updated (2)
Status Path Size Limits
✅ **/*.js
 621.81KB (+6.17KB +1%) -
✅ **/*.css
 29.72KB (-1.14KB -3.69%) -
Unchanged groups (1)
Status Path Size Limits
✅ img/.
 19.97KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

cballevre
cballevre approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@cballevre cballevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zatteo zatteo merged commit 6b26d84 into master Nov 6, 2024
2 checks passed
@zatteo zatteo deleted the feat/update-deps branch November 6, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cballevre cballevre cballevre approved these changes

@ecnivtwelve ecnivtwelve Awaiting requested review from ecnivtwelve ecnivtwelve is a code owner

@paultranvan paultranvan Awaiting requested review from paultranvan

@Merkur39 Merkur39 Awaiting requested review from Merkur39

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zatteo @cballevre @Merkur39