Feat/sharing label #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edas
force-pushed
the
feat/sharing-label
branch
from
e01b73f to
bb3f24e
Compare
edas
force-pushed
the
feat/sharing-label
branch
from
bb3f24e to
4e6f6c5
Compare
Not sure about the wrapper, but a prop to inject classnames is definitely welcome! |
Crash--
approved these changes
Jan 15, 2020
cozy-bot
pushed a commit
that referenced
this pull request
Jan 16, 2020
generated from commit 82932e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the labelonsharing button for views > 1024px
We strip it on smaller views to leave space for the prosemirror toolbar.
Two things for which comments are welcome :
I sharing.styl I use a css rule to hide the label of the sharing button. This rule have to know how we render the button internals. I plan to add wrapper around the label in cozy-sharing, and a props allowing to inject a classname for this wrapper. Would this be ok for you?
In index.css line 102-107 we have a useless block. Removing it would make the following block ignored. This is usually because of a syntax error above, but I fail to see where.
This dirty hack was already present before this change, from the proof of concept, but I would welcome suggestions to remove it now.