fix(Viewer): Now use intent inner dialog backdrop instead of custom one #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JF-Cozy
requested review from
Merkur39,
Ldoppea,
zatteo and
doubleface
as code owners
Merkur39
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Le fait d'utiliser Portal faisait qu'une fois l'intent ouvert, avec un input dans la modale, un onBlur était exécuté de suite après le onFocus. Donc impossible d'éditer le champ.
Ici on utilise le comportement par défaut, à savoir une Dialog, qui elle-même embarque Portal et Backdrop. On remplace simplement le PaperComponent pour avoir le rendu attendu, à savoir uniquement le Backdrop visible.