Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove cordova methods from cozy-device-helper #2664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Remove cordova methods from cozy-device-helper #2664

wants to merge 1 commit into from

Conversation

zatteo
Copy link
Contributor

@zatteo zatteo commented Dec 13, 2024 •
edited
Loading

To do :

  • vérifier s'il y a encore des usages légitimes des fonctions supprimées
  • bien documenter le breaking change pour qu'on puisse mettre à jour sans réfléchir

@zatteo zatteo force-pushed the feat/clean-cordova-logic branch from ae6a50c to 7c57ad4 Compare January 13, 2025 14:04
@zatteo
feat: Remove cordova related methods
e80d2e7 
BREAKING CHANGE: Every cordova related methods
have been removed.

When updating, if you find a method below, it is probably dead code
that you can remove. :
- hasDevicePlugin,
- hasInAppBrowserPlugin,
- hasSafariPlugin,
- hasNetworkInformationPlugin
- checkApp
- startApp
- nativeLinkOpen
- openDeeplinkOrRedirect
- getDeviceName

When updating, if you find a method below, keep what is relevant,
i.e. what is related to `isWebApp()` or `!isMobileApp()` or
`!isCordova()` :
- isCordova
- getPlatform
- isIOSApp
- isAndroidApp
- isMobileApp
- isWebApp
@zatteo zatteo force-pushed the feat/clean-cordova-logic branch from 7c57ad4 to e80d2e7 Compare January 13, 2025 14:05
@zatteo zatteo marked this pull request as ready for review January 13, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JF-Cozy JF-Cozy Awaiting requested review from JF-Cozy JF-Cozy is a code owner

@Merkur39 Merkur39 Awaiting requested review from Merkur39 Merkur39 is a code owner

@Ldoppea Ldoppea Awaiting requested review from Ldoppea Ldoppea is a code owner

@doubleface doubleface Awaiting requested review from doubleface doubleface is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zatteo