[PRD-600] feat: Use local search only for long-term sessions #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultranvan
force-pushed
the
localAndRemoteSearch
branch
from
15e2d87 to
f1e59cc
Compare
paultranvan
added a commit
to cozy/cozy-web-data-proxy
that referenced
this pull request
Nov 7, 2024
We now rely on the checkbox on login to determine whether or not the local search should be used. If the user enable this checkbox, it means he trusts this device and accept to store local data on it. Otherwise, we do not store any private data. See cozy/cozy-libs#2611 for the search part.
paultranvan
force-pushed
the
localAndRemoteSearch
branch
7 times, most recently
from
1a2caac to
9f8274f
Compare
We now rely on the checkbox on login to determine whether or not the local search should be used. If the user enable this checkbox, it means he trusts this device and accept to store local data on it. Otherwise, we do not store any private data, and directly query the stack to build the search index. Note the update mechanism is the same and rely on realtime. The difference is that we do not replicate the document for non local search.
paultranvan
force-pushed
the
localAndRemoteSearch
branch
from
9f8274f to
a5b63a1
Compare
paultranvan
added a commit
to cozy/cozy-web-data-proxy
that referenced
this pull request
Nov 8, 2024
We now rely on the checkbox on login to determine whether or not the local search should be used. If the user enable this checkbox, it means he trusts this device and accept to store local data on it. Otherwise, we do not store any private data. See cozy/cozy-libs#2611 for the search part.
paultranvan
added a commit
to cozy/cozy-web-data-proxy
that referenced
this pull request
Nov 8, 2024
We now rely on the checkbox on login to determine whether or not the local search should be used. If the user enable this checkbox, it means he trusts this device and accept to store local data on it. Otherwise, we do not store any private data. See cozy/cozy-libs#2611 for the search part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now rely on the checkbox on login to determine whether or not the local search should be used. If the user enable this checkbox, it means he trusts this device and accept to store local data on it. Otherwise, we do not store any private data, and directly query the stack to build the search index.
Note the update mechanism is the same and rely on realtime. The difference is that we do not replicate the document for non local search.