Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable DataProxy's iframe when running inside of Flagship app #2250

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Ldoppea
Copy link
Member

@Ldoppea Ldoppea commented Nov 19, 2024

When running inside of Flagship app, we don't want to load the DataProxy's iframe

Instead we want to use the Flagship app's API

For now this API does not exist, so we just disable the DataProxy feature

We could have enabled the iframe until the native API is implemented, but for now this would introduce an infinite nested iframes bug as the Flagship app's WebViews intercept all requests to / or /index.html and inject the cozy-home code

### ✨ Features

*

### 🐛 Bug Fixes

* Disable DataProxy in Flagship app

### 🔧 Tech

*

When running inside of Flagship app, we don't want to load the
DataProxy's iframe

Instead we want to use the Flagship app's API

For now this API does not exist, so we just disable the DataProxy
feature

We could have enabled the iframe until the native API is implemented,
but for now this would introduce an infinite nested iframes bug as the
Flagship app's WebViews intercept all requests to `/` or `/index.html`
and inject the cozy-home code
Copy link

bundlemon bot commented Nov 19, 2024

BundleMon

Files updated (2)
Status Path Size Limits
intents/home.(hash).js
26.61KB (+42B +0.15%) -
app/home.(hash).js
56.26KB (+32B +0.06%) -
Unchanged files (11)
Status Path Size Limits
vendors/home.(hash).js
1.57MB -
services/softDeleteOrRestoreAccounts/home.js
466.04KB -
services/updateAccounts/home.js
463.17KB -
services/deleteAccounts/home.js
311.82KB -
services/myselfFromIdenties/home.js
236.25KB -
services/polyfillFetch/home.js
97.38KB -
vendors-home.(hash).(hash).min.css
37.78KB -
services/attributesHelpers/home.js
15.22KB -
app-home.(hash).min.css
2.21KB -
intents/index.html
652B -
intents-home.(hash).min.css
158B -

Total files change +74B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

@cballevre cballevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ldoppea Ldoppea merged commit 61a2dea into master Nov 20, 2024
4 checks passed
@Ldoppea Ldoppea deleted the fix/disable_dataproxy_in_flagship branch November 20, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants