Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Assistant): Show instant message sorted by position #2236

Merged
merged 2 commits into from
Oct 31, 2024
Merged

feat(Assistant): Show instant message sorted by position #2236

merged 2 commits into from
Oct 31, 2024

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Oct 31, 2024 •
edited
Loading

No description provided.

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 31, 2024

BundleMon

Files updated (2)
Status Path Size Limits
✅ app/home.(hash).js
 56.54KB (+754B +1.32%) -
✅ intents/home.(hash).js
 27.46KB (+98B +0.35%) -
Unchanged files (11)
Status Path Size Limits
✅ vendors/home.(hash).js
 1.54MB -
✅ services/softDeleteOrRestoreAccounts/home.js
 464.4KB -
✅ services/updateAccounts/home.js
 461.47KB -
✅ services/deleteAccounts/home.js
 309.8KB -
✅ services/myselfFromIdenties/home.js
 234.35KB -
✅ services/polyfillFetch/home.js
 97.37KB -
✅ vendors-home.(hash).(hash).min.css
 38.79KB -
✅ services/attributesHelpers/home.js
 15.22KB -
✅ app-home.(hash).min.css
 2.21KB -
✅ intents/index.html
 651B -
✅ intents-home.(hash).min.css
 158B -

Total files change +852B +0.03%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

Merkur39
Merkur39 approved these changes Oct 31, 2024
View reviewed changes
src/assistant/AssistantProvider.jsx Outdated
@@ -7,6 +8,12 @@ import { CHAT_EVENTS_DOCTYPE, CHAT_CONVERSATIONS_DOCTYPE } from './queries'

export const AssistantContext = React.createContext()

export const getInstantMessage = assistantState =>
Object.keys(assistantState.message)
.sort((a, b) => a - b)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.sort() est suffisant pour trier dans cet ordre

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non sur les number ça va faire 1 puis 11 puis 111 alors qu'avec la fonction actuelle ça va faire 1 puis 2 puis 3 ... puis 11

@JF-Cozy JF-Cozy merged commit 913059a into master Oct 31, 2024
4 checks passed
@JF-Cozy JF-Cozy deleted the feat/VER-967 branch October 31, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Merkur39 Merkur39 Merkur39 approved these changes

@cballevre cballevre Awaiting requested review from cballevre

@Ldoppea Ldoppea Awaiting requested review from Ldoppea Ldoppea is a code owner

@doubleface doubleface Awaiting requested review from doubleface doubleface is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JF-Cozy @Merkur39