fix: Make the search work for cozy-apps again #2227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the search engine now uses a local PouchDB, the documents are not JSON-API compliant, so we should rely on
_type
instead oftype
With previous implementation, we failed to compute icon for cozy-apps due to missing
doc.type
attribute, and returned theunknown
type. This type was not handled by the<ResultMenuItem>
item and the application would crashThis PR fixes the usage of the
_type
attribute but also return a default icon instead ofunknown
to prevent future crashes