Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Assistant): Add FAB on search page for mobile #2224

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Oct 22, 2024

No description provided.

Copy link

bundlemon bot commented Oct 22, 2024

BundleMon

Files updated (2)
Status Path Size Limits
app/home.(hash).js
54.98KB (+270B +0.48%) -
intents/home.(hash).js
28.87KB (+19B +0.06%) -
Unchanged files (11)
Status Path Size Limits
vendors/home.(hash).js
1.53MB -
services/softDeleteOrRestoreAccounts/home.js
464.4KB -
services/updateAccounts/home.js
461.47KB -
services/deleteAccounts/home.js
309.8KB -
services/myselfFromIdenties/home.js
234.35KB -
services/polyfillFetch/home.js
97.37KB -
vendors-home.(hash).(hash).min.css
38.79KB -
services/attributesHelpers/home.js
15.22KB -
app-home.(hash).min.css
2.13KB -
intents/index.html
651B -
intents-home.(hash).min.css
158B -

Total files change +289B +0.01%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

import { getFlagshipMetadata } from 'cozy-device-helper'
import { useI18n } from 'cozy-ui/transpiled/react/providers/I18n'

const useStyles = makeStyles({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Make a FixedFab to factorize the code with the AddButton (code)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je n'irai pas jusque là... Le composant vient directement de la doc cozy-ui donc pas besoin de mutualiser les props je pense. Reste le style par contre avec la petite astuce pour flagship app, à voir 🤔

@JF-Cozy JF-Cozy merged commit 1fe8219 into master Oct 23, 2024
4 checks passed
@JF-Cozy JF-Cozy deleted the feat/VER-1014 branch October 23, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants