Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assistant: adjust resultmenu zindex and mobile searchbar position #2214

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Assistant: adjust resultmenu zindex and mobile searchbar position #2214

merged 2 commits into from
Oct 17, 2024

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Oct 17, 2024 •
edited
Loading

No description provided.

@JF-Cozy
feat(Assistant): Put mobile search bar on body with portal
16fed15 
we need the component to be among the routes in order to access the router. Except that to get the fixed style, the component has to be outside the MainView... so we use Portal for that.
@JF-Cozy
feat(Assistant): Set correct z-index for ResultMenu
b87e23d
@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 17, 2024

BundleMon

Files updated (2)
Status Path Size Limits
✅ vendors/home.(hash).js
 1.53MB (+34B 0%) -
✅ app/home.(hash).js
 54.74KB (+18B +0.03%) -
Unchanged files (11)
Status Path Size Limits
✅ services/softDeleteOrRestoreAccounts/home.js
 464.4KB -
✅ services/updateAccounts/home.js
 461.47KB -
✅ services/deleteAccounts/home.js
 309.8KB -
✅ services/myselfFromIdenties/home.js
 234.35KB -
✅ services/polyfillFetch/home.js
 97.37KB -
✅ vendors-home.(hash).(hash).min.css
 38.79KB -
✅ intents/home.(hash).js
 28.85KB -
✅ services/attributesHelpers/home.js
 15.22KB -
✅ app-home.(hash).min.css
 2.14KB -
✅ intents/index.html
 651B -
✅ intents-home.(hash).min.css
 158B -

Total files change +50B 0%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@JF-Cozy JF-Cozy merged commit 4220cd4 into master Oct 17, 2024
4 checks passed
@JF-Cozy JF-Cozy deleted the feat/VER-992-1 branch October 17, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acezard acezard Awaiting requested review from acezard

@doubleface doubleface Awaiting requested review from doubleface doubleface is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JF-Cozy