Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow long text in AppHighlightAlert #2026

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

zatteo
Copy link
Contributor

@zatteo zatteo commented Oct 27, 2023

I had to play with margin-bottom on AppHighlightAlert and grid-gap to counterbalance the removal of auto-fit.

### ✨ Features

* Allow long text in AppHighlightAlert

Screenshot 2023-10-27 at 12 09 33
Screenshot 2023-10-27 at 12 09 39

@zatteo zatteo requested a review from cballevre October 27, 2023 10:26
@zatteo zatteo force-pushed the feat/allow-long-text-in-app-highlight-alert branch from 1f07224 to 0b89c11 Compare October 27, 2023 10:27
I had to play with margin-bottom on AppHighlightAlert and grid-gap to
counterbalance the removal of auto-fit.
@zatteo zatteo force-pushed the feat/allow-long-text-in-app-highlight-alert branch from 0b89c11 to 3be55b2 Compare October 27, 2023 11:17
@bundlemon
Copy link

bundlemon bot commented Oct 27, 2023

BundleMon

Files updated (1)
Status Path Size Limits
app/home.(hash).js
44.07KB (+19B +0.04%) 50KB
Unchanged files (12)
Status Path Size Limits
vendors/home.(hash).js
1.21MB 1.5MB
services/softDeleteOrRestoreAccounts/home.js
488.01KB 490KB
services/updateAccounts/home.js
463.41KB 464KB
services/deleteAccounts/home.js
321.95KB 500KB
services/myselfFromIdenties/home.js
237.11KB 240KB
services/polyfillFetch/home.js
98.38KB 99KB
intents/home.(hash).js
33.41KB 35KB
vendors-home.(hash).(hash).min.css
30.02KB 35KB
services/attributesHelpers/home.js
15.13KB 16KB
app-home.(hash).min.css
14.1KB 15KB
intents-home.(hash).min.css
5.78KB 6KB
intents/index.html
501B 1KB

Total files change +15B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@zatteo zatteo merged commit da990e6 into master Oct 27, 2023
4 checks passed
@zatteo zatteo deleted the feat/allow-long-text-in-app-highlight-alert branch October 27, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants