Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an AppHighlightAlert targeting coachco2 #2022

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Add an AppHighlightAlert targeting coachco2 #2022

merged 3 commits into from
Oct 24, 2023

Conversation

zatteo
Copy link
Contributor

@zatteo zatteo commented Oct 20, 2023 

### ✨ Features

 * Add a pointer alert to present geolocation tracking feature

### 🔧 Tech

 * Manage multiple alerts

image

zatteo added 2 commits October 20, 2023 12:30
@zatteo
refactor: Add logic to manage multiple AppHighlightAlert
8f149e3 
Multiple AppHighlightAlert will be available soon. We need to be able
to :
- check the available ones => flag enabled for backup example
- check the displayable ones => at second time we open the home for
backup example
- select one to display when there are multiple displayables ones
- do not display anymore when an AppHighlightAlert has been shown
@zatteo
feat: Add an GeolocationTrackingAppHighlightAlert
926a2aa
@bundlemon
Copy link

bundlemon bot commented Oct 20, 2023 •
edited
Loading

BundleMon

Files updated (2)
Status Path Size Limits
✅ app/home.(hash).js
 44.12KB (+793B +1.79%) 50KB
✅ intents/home.(hash).js
 33.49KB (+349B +1.03%) 35KB
Unchanged files (11)
Status Path Size Limits
✅ vendors/home.(hash).js
 1.21MB 1.5MB
✅ services/softDeleteOrRestoreAccounts/home.js
 485.53KB 487KB
✅ services/updateAccounts/home.js
 461.33KB 464KB
✅ services/deleteAccounts/home.js
 320.18KB 500KB
✅ services/myselfFromIdenties/home.js
 235.31KB 240KB
✅ services/polyfillFetch/home.js
 98.38KB 99KB
✅ vendors-home.(hash).(hash).min.css
 30.02KB 35KB
✅ services/attributesHelpers/home.js
 15.13KB 16KB
✅ app-home.(hash).min.css
 14.1KB 15KB
✅ intents-home.(hash).min.css
 5.78KB 6KB
✅ intents/index.html
 500B 1KB

Total files change +1.12KB +0.04%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@zatteo zatteo requested review from Crash-- and cballevre October 23, 2023 07:36
@zatteo
fix: Allow to display HighlightAlert at first launch
f7ee1af 
If we want to display an HighlightAlert at first launch,
APP_START_COUNT_KEY is NaN.

NaN ?? 0 => NaN
NaN || 0 => 0
Crash--
Crash-- reviewed Oct 24, 2023
View reviewed changes
src/components/AppHighlightAlert/AppHighlightAlertWrapper.jsx
const appHighlightAlerts = [
getBackupAppHighlightAlert(),
getGeolocationTrackingAppHighlightAlert()
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the first in that array has the priority, and so on?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We did not chose any way to set a priority for the moment.

@zatteo zatteo merged commit 9207b89 into master Oct 24, 2023
4 checks passed
@zatteo zatteo deleted the feat/app-highlight-alert-geoloc branch October 24, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crash-- Crash-- Crash-- left review comments

@cballevre cballevre cballevre approved these changes

@acezard acezard Awaiting requested review from acezard

@doubleface doubleface Awaiting requested review from doubleface doubleface is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zatteo @Crash-- @cballevre