Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/remove ccjs #1991

Merged
merged 43 commits into from
Dec 20, 2023
Merged

Feat/remove ccjs #1991

merged 43 commits into from
Dec 20, 2023

Conversation

Crash--
Copy link
Contributor

@Crash-- Crash-- commented Aug 21, 2023 •
edited
Loading 

### 🔧 Tech

* Remove cozy-client-js 
* Use harvest everywhere. No more manual konnector modal.

@Crash-- Crash-- force-pushed the feat/removeCCJS branch 2 times, most recently from d418b8b to 8d99203 Compare October 19, 2023 09:46
@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 14, 2023 •
edited
Loading

BundleMon

Files updated (6)
Status Path Size Limits
✅ intents/index.html
 546B (+48B +9.64%) 1KB
✅ app-home.(hash).min.css
 14.1KB (-25B -0.17%) 15KB
✅ intents-home.(hash).min.css
 3.23KB (-2.53KB -43.87%) 6KB
✅ app/home.(hash).js
 36.56KB (-7.63KB -17.27%) 50KB
✅ intents/home.(hash).js
 23.02KB (-10.38KB -31.08%) 35KB
✅ vendors/home.(hash).js
 1.21MB (-14.24KB -1.14%) 1.5MB
Unchanged files (7)
Status Path Size Limits
✅ services/softDeleteOrRestoreAccounts/home.js
 480.57KB 490KB
✅ services/updateAccounts/home.js
 464.46KB 465KB
✅ services/deleteAccounts/home.js
 313.62KB 500KB
✅ services/myselfFromIdenties/home.js
 237.84KB 240KB
✅ services/polyfillFetch/home.js
 98.39KB 99KB
✅ vendors-home.(hash).(hash).min.css
 30.04KB 35KB
✅ services/attributesHelpers/home.js
 15.12KB 16KB

Total files change -34.77KB -1.16%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@cballevre cballevre requested a review from zatteo December 8, 2023 14:33
@Crash-- Crash-- changed the title [WIP] Feat/remove ccjs Feat/remove ccjs Dec 15, 2023
Crash-- added 18 commits December 20, 2023 15:49
@Crash-- @cballevre
fix: Use Cozy-Client store for KonnectorTile
6f3ae0d 
We had a few issues with the data persistence within the flagship app.
This is mostly due to the fact that we have a lot of way to manage data
for the Home application.

Here, I remove the `fetchTriggers` to use query(Q('io.cozy.triggers'))
everywhere within the app.

I also changed the konnectorTile to use data from the cozy-client store
instead of the one from the Home.
@Crash-- @cballevre
refactor: Remove redux-cozy-client
2dc899e
@Crash-- @cballevre
fix: Tmp commit since there is a bug in the stack
0c648a7 
Stack returns twice the app when served by --serve option in dev mode
resulting in a lot of warning in the console. Made a quick dedup
@Crash-- @cballevre
feat: Remove old cozy-client-js stuff
5a6e511
@Crash-- @cballevre
refactor: Usequery() instead of relying on the store directly
2574c5d
@Crash-- @cballevre
refactor: Use reselect + useSelector instead of mapStateToProps
9f4ea7e
@Crash-- @cballevre
refactor: Rely on realtime instead of redux action
04341fe
@Crash-- @cballevre
refactor: Convert IntentSErvice to functionnal component
c8c6f98
@Crash-- @cballevre
refactor: Use cozy-intent instead of cozy-client-js
4f27dca 
feat: Upgrade CC to fix tests
@Crash-- @cballevre
refactor: Use Harvest
12217f6 
Instead of having our own implementation
@Crash-- @cballevre
refactor: Use triggers from appEntry and don't make the request twice
12774c6
@Crash-- @cballevre
refactor: No need of konnector middleware
5a1f9fb
@Crash-- @cballevre
refactor: Use Realtime queries
9254b02
@Crash-- @cballevre
reactor: Remove unuseud function
b9eacee
@Crash-- @cballevre
refactore: Remove files
d5b962e
@Crash-- @cballevre
refactor: Remove CSS style
aed79c7
@Crash-- @cballevre
fix: Intent can be dismissed
ff2c3f7 
This intent should be called with closable=false since Harvest will
handle by itself how to cancel.
@Crash-- @cballevre
tests: Remove deleted test
dd47719
Crash-- and others added 25 commits December 20, 2023 15:49
@Crash-- @cballevre
fix: useSelect can return empty. We want an []
b794ba3
@Crash-- @cballevre
tests: Fix Services Test
2dd2dd2
@Crash-- @cballevre
tests: KonnectorTile
fc12e64 
- Move the file close to its component
- make it dynamic for the konnector name
- Split describe in order to have UI and no UI stuff
@Crash-- @cballevre
fix: Add the userError
86ad0c4 
Need to check why I've removed it recently.
@Crash-- @cballevre
fix: KonnectorTile doesn't have route props
cba39c5
@Crash-- @cballevre
fix: Add lang to useI18n type
d6d2bc0
@Crash-- @cballevre
fix: Add ts-check and fix errors
9aedaa0
@Crash-- @cballevre
fix: KonnectorTile
b81da2f
@Crash-- @cballevre
tests: Remove this test, not needed anymore
49e8cde
@Crash-- @cballevre
fix: Add Divider
8ae1c1a 
It was previoulsy done by KonnectorsErrors, but since
we've removed it, it was not there anymore.
@Crash-- @cballevre
refactor: Import order
c0a6538
@Crash-- @cballevre
refactor: Remove cozy-client-js
e827429
@Crash-- @cballevre
fix: Lint issue
5cca5ad
@Crash-- @cballevre
fix: Request only triggers for worker and clisk
579ea05
@Crash-- @cballevre
feat: Display datacard options also for the Intent from the Store
082d1dd
@cballevre
fix: Import error from migration cozy-ui 93.0.0
7eefc14
@cballevre
feat: Hide the harvest close button to show only the Intent one
b8bcd34
@Crash-- @cballevre
fix: Lint
1f0a85e
@Crash-- @cballevre
docs: Document Slug for Create account
63a135c
@Crash-- @cballevre
feat: Use new feature of cozy-interapp
52eb3ad 
Let's the Intent Service tell the IntentModal that the cross should
be hidden

Depends on:
cozy/cozy-ui#2520
cozy/cozy-libs#2323
@Crash-- @cballevre
feat: Add VIEW INTENT
501256d 
The idea is to be able to display an account from every where.
This intent is not directly used in production, but it's useful to test
the end (aka the display of harvest) of the intent
create io.cozy.accounts.

I used it to debug the "open in Drive" feature, since the link was not
working.
@Crash-- @cballevre
feat: Pass the intentData & intentId to the Harvest Route
9162caf
@Crash-- @cballevre
fix: Add the same cozy-* attributes as the targets/browser
1d339f0 
Because Harvest is based on `cozySubdomainType` and we didn't have it
in this template, it didn't work in the intents. So I added the same
attributes as the browser ones.
@Crash-- @cballevre
fix: Typing issue
2c7ddc6
@Crash-- @cballevre
test: Remove old snapshops
d6bb2e4
@cballevre cballevre merged commit dc0c53e into master Dec 20, 2023
5 checks passed
@cballevre cballevre deleted the feat/removeCCJS branch December 20, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cballevre cballevre cballevre left review comments

@acezard acezard Awaiting requested review from acezard

@doubleface doubleface Awaiting requested review from doubleface doubleface is a code owner

@zatteo zatteo Awaiting requested review from zatteo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Crash-- @cballevre