Skip to content

Commit

Permalink
fix: Force android tools version on CI when signing APK
Browse files Browse the repository at this point in the history
Since January 8 the  `ubuntu-latest` image excludes Android SDKs prior
to version 31

By default the `r0adkll/sign-android-release` package uses
Android SDK 29. So the build would fail

In order to fix that, we can set the `BUILD_TOOLS_VERSION` env variable
to define which version `r0adkll/sign-android-release` should use

Related doc:
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md

Related issue: r0adkll/sign-android-release#84
  • Loading branch information
Ldoppea committed Jan 19, 2024
1 parent afe69fd commit 0f56cdd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/build-android-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ jobs:
alias: ${{ secrets[format('{0}_ANDROID_ALIAS', inputs.brand)] }}
keyStorePassword: ${{ secrets[format('{0}_ANDROID_KEY_STORE_PASSWORD', inputs.brand)] }}
keyPassword: ${{ secrets[format('{0}_ANDROID_KEY_PASSWORD', inputs.brand)] }}
env:
BUILD_TOOLS_VERSION: "33.0.0"

- name: Upload Dev artifact to GitHub
uses: actions/upload-artifact@v3
Expand All @@ -128,6 +130,8 @@ jobs:
alias: ${{ secrets[format('{0}_ANDROID_ALIAS', inputs.brand)] }}
keyStorePassword: ${{ secrets[format('{0}_ANDROID_KEY_STORE_PASSWORD', inputs.brand)] }}
keyPassword: ${{ secrets[format('{0}_ANDROID_KEY_PASSWORD', inputs.brand)] }}
env:
BUILD_TOOLS_VERSION: "33.0.0"

- name: Upload Prod artifact to GitHub
uses: actions/upload-artifact@v3
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build-android-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ jobs:
alias: ${{ secrets[format('{0}_ANDROID_ALIAS', inputs.brand)] }}
keyStorePassword: ${{ secrets[format('{0}_ANDROID_KEY_STORE_PASSWORD', inputs.brand)] }}
keyPassword: ${{ secrets[format('{0}_ANDROID_KEY_PASSWORD', inputs.brand)] }}
env:
BUILD_TOOLS_VERSION: "33.0.0"

- name: Upload AAB artifact to GitHub
uses: actions/upload-artifact@v3
Expand Down

0 comments on commit 0f56cdd

Please sign in to comment.