Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FilesViewerLoading was imported from a file that did not export it #3239

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Oct 29, 2024

ça ne posait pas de souci avec un usage classique de l'app : chargement de la home, puis navigation dans les dossier/fichier. Car la requête de récupération des fichiers est exécuté au lancement de l'app, et donc la navigation se fait sur le cache. Usequery dans les composants retourne alors toujours un tableau et non un null. On ne passe donc jamais dans le FilesViewerLoading.

Sauf qu'avec un refresh sur la visualisation d'un fichier, la query est réinitialisée, donc on passe par un null, donc l'app plantait car l'import n'était pas bon.

Copy link

bundlemon bot commented Oct 29, 2024

BundleMon

Files updated (2)
Status Path Size Limits
public/drive.(hash).js
1.56MB (-103B -0.01%) 1.7MB
app/drive.(hash).js
161.01KB (-112B -0.07%) 300KB
Unchanged files (16)
Status Path Size Limits
vendors/drive.(hash).js
1.79MB 2MB
public/pdf.worker.entry.(hash).worker.js
345.35KB 350KB
services/qualificationMigration/drive.js
282.15KB 500KB
services/dacc/drive.js
263.08KB 500KB
public/cozy-client-js.js
159.28KB 160KB
intents/drive.(hash).js
87.66KB 190KB
public/drive.(hash).min.css
39.94KB 100KB
onlyOffice/slide.pptx
24.83KB 25KB
app-drive.(hash).min.css
10.73KB 56KB
intents-drive.(hash).min.css
7.89KB 40KB
onlyOffice/text.docx
5.85KB 6KB
onlyOffice/spreadsheet.xlsx
5.02KB 6KB
manifest.webapp
1.87KB 2KB
index.html
594B 1KB
intents/index.html
507B 1KB
manifest.json
185B 1KB

Total files change -218B 0%

Groups updated (2)
Status Path Size Limits
public/**
2.11MB (-104B 0%) -
app/**
161.01KB (-112B -0.07%) -
Unchanged groups (5)
Status Path Size Limits
vendors/**
1.79MB -
services/**
545.23KB -
intents/**
88.15KB -
onlyOffice/**
35.7KB -
img/**
5.85KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@JF-Cozy JF-Cozy merged commit 077db1f into master Oct 29, 2024
4 checks passed
@JF-Cozy JF-Cozy deleted the fix/VER-1041 branch October 29, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant